fix: switch to new page failed after copy page

[chilingling]

English | 简体中文

PR

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our Commit Message Guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)
• Built its own designer, fully self-validated

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

Background and solution

【问题描述】
新建页面/复制页面成功之后，画布有可能切换新页面失败，并提示报错。

【问题分析】
创建页面后，会执行一下步骤：

1. 调用 pageSettingState.updateTreeData() 更新页面状态相关变量。该方法为异步。
2. 调用 emit('openNewPage', data)，将当前编辑页面切换到新创建的页面。
3. 画布会根据页面 id，调用相关方法（getAncestors），获取 treeDataMapping 中的对应状态。

问题：当第 3 步更新比第 1 步的异步更新先执行时，导致了报错。

【解决方案】

pageSettingState.updateTreeData() 改为异步等待 await pageSettingState.updateTreeData()

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

• Yes
• No

Other information

Summary by CodeRabbit

• Refactor
  • Improved the reliability and consistency of the page creation process, resulting in better error handling and smoother user experience.

[coderabbitai]

Walkthrough

The asynchronous logic for creating a new page in PageSetting.vue was refactored from a promise-based .then().catch() approach to using async/await with a try/catch block. No changes to exported or public entities were made; all modifications are internal to the createPage method.

Changes

File(s)	Change Summary
packages/plugins/page/src/PageSetting.vue	Refactored createPage method from promise chaining to async/await with centralized error handling.

Poem

In the warren of code, a promise once lay,
Now awaits and tries light up the way.
Errors caught in a gentle embrace,
Async hops quick, keeping pace.
With each new page, a story anew—
Refactored and tidy, for all to view!
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 684832b and 13b85d8.

📒 Files selected for processing (1)

• packages/plugins/page/src/PageSetting.vue (1 hunks)

🔇 Additional comments (1)

packages/plugins/page/src/PageSetting.vue (1)

195-217: Great refactoring to fix the race condition!

The refactoring from Promise chains to async/await pattern effectively addresses the race condition mentioned in the PR objectives. By awaiting pageSettingState.updateTreeData() before emitting the 'openNewPage' event, you ensure that the page state is fully updated before the canvas attempts to switch to the new page, preventing the error where the canvas tries to access incomplete state data.

This is a clean implementation that improves both functionality and code readability.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.