fix: genCodeUnitTest failed

[chilingling]

English | 简体中文

PR 修复出码单元测试

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our Commit Message Guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)
• Built its own designer, fully self-validated

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

Background and solution

1. 修复添加 currentColor 后单元缺失的 bug。
2. 修复修改 eslint 之后 expected 文件未同步修改导致单元测试失败的问题
3. 增加出码 key 合法性检测，如果不合法，出码时，为 key 增加引号，避免因为没有添加引号导致的出码错误。
4. 兼容 linux 和 window 系统因为换行符不同引起的对比差异，导致单元测试失败。

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

• Yes
• No

Other information

Summary by CodeRabbit

• New Features

  • Added a base public path for improved application deployment.
  • Extended component state with an additional property for enhanced management.

• Improvements

  • Enhanced object key formatting to ensure proper quoting and avoid syntax issues.
  • Simplified file writing process by removing line ending alterations.

• Style

  • Updated icon components to inherit the current text color, ensuring better visual integration.

[coderabbitai]

Walkthrough

This pull request introduces several enhancements to the Vue generator and associated test files. A new regular expression, normalKeyRegexp, is added to validate JavaScript variable names, modifying the key rendering logic in the transformObjType function. The file writing process in tests is updated to write content directly without altering line endings. Inline conditional expressions in various functions are replaced with explicit if statements for improved clarity. Additionally, the Vite configuration now includes a base public path, and certain icon components are updated to inherit the current text color through a fill attribute. New state properties are also added in the accessor tests and schema.

Changes

File(s)	Change Summary
packages/vue-generator/src/.../generateAttribute.js	Introduced normalKeyRegexp and updated transformObjType to format object keys based on validity.
packages/vue-generator/test/.../element-plus-case.test.js, packages/vue-generator/test/.../generateApp.test.js	Modified file content processing to write without altering line endings.
packages/vue-generator/test/.../element-plus-case/expected/appdemo01/src/http/axios.js, packages/vue-generator/test/.../element-plus-case/expected/appdemo01/src/lowcodeConfig/dataSource.js, packages/vue-generator/test/.../generator/expected/appdemo01/src/http/axios.js, packages/vue-generator/test/.../generator/expected/appdemo01/src/lowcodeConfig/dataSource.js	Replaced inline conditionals with explicit if statements for invoking handleData and for mock restoration; added an ESLint disable comment in axios files.
packages/vue-generator/test/.../element-plus-case/expected/appdemo01/vite.config.js, packages/vue-generator/test/.../generator/expected/appdemo01/vite.config.js	Added base: './' property to the Vite configuration.
packages/vue-generator/test/.../appdemo01/src/views/createVm.vue, packages/vue-generator/test/.../sfc/case01/expected/FormTable.vue	Added fill="currentColor" attribute for icon components to inherit current text color.
packages/vue-generator/test/.../sfc/accessor/accessor.test.js, packages/vue-generator/test/.../sfc/accessor/expected/Accessor.vue, packages/vue-generator/test/.../sfc/accessor/schema.json	Restructured test cases and added a new state property ('a.b': 'test') in both the Vue component and JSON schema.

Sequence Diagram(s)

sequenceDiagram
    participant T as transformObjType
    participant R as normalKeyRegexp
    T->>R: Test key validity (normalKeyRegexp.test(key))
    alt Valid key
        R-->>T: true
        T->>T: Format renderKey as `${key}: `
    else Invalid key
        R-->>T: false
        T->>T: Format renderKey as `'${key}': `
    end

Loading

Possibly related PRs

• fix: generate code accessor scenario #972: Modifies the transformObjType function with similar changes in key formatting.
• fix: state accessor defaultValue support expression #977 #997: Involves updates to the transformObjType logic, aligning with the regex-based validation.
• fix: jsx slot modelvalue can't update value #734: Introduces JSX model value updates in generateAttribute.js, addressing attribute handling similar to this PR.

Suggested labels

ready_for_review

Suggested reviewers

• hexqi
• rhlin

Poem

I hopped through lines of code so clear,
Shifting conditionals with a cheerful cheer.
Keys now shine with proper quotes in view,
LF sings its song, crisp and new.
As I race through code with a joyful trot—
A coding rabbit, proud of the change I've got! 🐇

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 257ac38 and 23fa50f.

📒 Files selected for processing (2)

• packages/vue-generator/test/testcases/element-plus-case/element-plus-case.test.js (2 hunks)
• packages/vue-generator/test/testcases/generator/generateApp.test.js (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• packages/vue-generator/test/testcases/generator/generateApp.test.js

⏰ Context from checks skipped due to timeout of 90000ms (2)

• GitHub Check: label
• GitHub Check: push-check

🔇 Additional comments (2)

packages/vue-generator/test/testcases/element-plus-case/element-plus-case.test.js (2)

32-32: Improved file writing by removing line ending conversion.

The code now writes string content directly to files without modifying line endings, which simplifies the process and is more consistent. This aligns with the PR objective of fixing test failures related to file content expectations.

---

45-47: Enhanced file comparison configuration.

The addition of explicit file comparison handlers (compareFileSync and compareFileAsync) and the ignoreEmptyLines option improves the robustness of the test comparisons. These changes help prevent test failures caused by irrelevant differences like line endings or empty lines, which addresses the PR objective of fixing ESLint-related test failures.

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.