fix：set default redirect page, but after modification, an error message appears indicating successful save

[lichunn]

English | 简体中文

PR

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our Commit Message Guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)
• Built its own designer, fully self-validated

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

Background and solution

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

• Yes
• No

Other information

Summary by CodeRabbit

• Refactor
  • Adjusted the workflow underlying page updates to enhance the timing and reliability of editing operations, resulting in a smoother experience when pages are modified.

[coderabbitai]

Walkthrough

This pull request modifies the asynchronous handling in the PageSetting.vue file. The settingDefaultPage function no longer awaits the updatePage call but instead uses a .then() chain to conditionally invoke editPage if the response is truthy. Additionally, the direct chaining of editPage from within createHistoryMessage has been removed, altering the control flow for page updates. No changes were made to exported or public entities.

Changes

File(s)	Change Summary
packages/.../PageSetting.vue	Updated settingDefaultPage to call updatePage without awaiting and added a .then() to conditionally call editPage. Removed chaining of editPage from createHistoryMessage.

Sequence Diagram(s)

sequenceDiagram
    participant PS as PageSetting.vue
    participant UP as updatePage
    participant EP as editPage

    PS->>UP: Call updatePage() without await
    UP-->>PS: Return promise result
    alt Response is truthy
        PS->>EP: Call editPage() via .then()
    else Response is falsy
        PS-->PS: No editPage call
    end

Loading

Possibly related PRs

• feat：adjust the homepage and default page settings mode #1214: Adjustments to page update handling, particularly in the handlePageUpdate function, have a strong code-level connection with the changes to settingDefaultPage and updatePage in this PR.

Suggested labels

bug, refactor-main

Suggested reviewers

• hexqi

Poem

I’m a little rabbit with a codey beat,
Hop-frogging through changes, light on my feet.
Async paths now flow clear and bright,
With bugs and errors taking flight.
A joyful nod to a refactor done right!
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 730bfb9 and 33673f2.

📒 Files selected for processing (1)

• packages/plugins/page/src/PageSetting.vue (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: push-check

🔇 Additional comments (2)

packages/plugins/page/src/PageSetting.vue (2)

313-317: Improved error handling in settingDefaultPage function

The Promise chain approach is more robust than the previous implementation. By conditionally calling editPage() only when the response from updatePage() is truthy, you prevent unnecessary page edits when the update fails or returns a falsy value.

---

332-332: Fixed control flow in createHistoryMessage function

Removing the .then(editPage) chain from the settingDefaultPage() call eliminates the potential double invocation of editPage(). This change aligns with the modifications made to the settingDefaultPage function which now handles the editPage() call internally when appropriate.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.