fix：After dragging and dropping the subpage to change the parent page, isDefault should be false

[lichunn]

English | 简体中文

PR

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our Commit Message Guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)
• Built its own designer, fully self-validated

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

Background and solution

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

• Yes
• No

Other information

Summary by CodeRabbit

• Bug Fixes
  • Improved page update behavior so that pages are consistently updated without inadvertently retaining default settings.

[coderabbitai]

Walkthrough

The pull request modifies the handleMoveNode function in the PageTree.vue component. A new line is added to explicitly set the isDefault property of the pageDetail object to false when the object represents a page (pageDetail.isPage is true). This modification ensures that the state of pageDetail is correctly updated before invoking the updatePage function. No changes were made to the exported or public entities.

Changes

File Path	Change Summary
packages/plugins/page/src/PageTree.vue	Modified handleMoveNode to set pageDetail.isDefault = false if pageDetail.isPage is true before calling updatePage(pageDetail)

Sequence Diagram(s)

sequenceDiagram
    participant U as User Action
    participant PT as PageTree Component
    participant API as updatePage Function
    U->>PT: Trigger handleMoveNode
    PT->>PT: Set pageDetail.isDefault = false (if isPage true)
    PT->>API: Call updatePage(pageDetail)

Loading

Possibly related PRs

• feat: page tree supports dragging #948: Directly related changes enhancing node movement in the tree structure by modifying node state management.

Suggested labels

bug, refactor-main

Suggested reviewers

• rhlin
• hexqi

Poem

In the land of code, I’m a hopping sprite,
Adjusting flags with a bound so light.
With a gentle tweak to set things right,
My rabbit code dances in pure delight.
Hoppin' through bugs and fixes all day—yay! 🐇💻

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 47d013a and d91f899.

📒 Files selected for processing (1)

• packages/plugins/page/src/PageTree.vue (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: push-check

🔇 Additional comments (1)

packages/plugins/page/src/PageTree.vue (1)

337-339: Good fix for the page dragging issue.

Setting isDefault to false when a page is moved to a new parent is a necessary change to ensure that dragged subpages aren't automatically set as default pages in their new location. This aligns perfectly with the PR objective.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.