Skip to content

fix: getRenderer could be null before canvas init#1254

Merged
hexqi merged 1 commit intoopentiny:developfrom
chilingling:fix/getRendererErrBeforeCanvasInit
Apr 8, 2025
Merged

fix: getRenderer could be null before canvas init#1254
hexqi merged 1 commit intoopentiny:developfrom
chilingling:fix/getRendererErrBeforeCanvasInit

Conversation

@chilingling
Copy link
Member

@chilingling chilingling commented Mar 27, 2025

English | 简体中文

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Built its own designer, fully self-validated

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Background and solution

截屏2025-03-29 11 42 28

在画布 ready 前,getRenderer 有可能是 null,需要判断

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

Summary by CodeRabbit

  • Bug Fixes
    • Enhanced error handling in the localization process to prevent runtime issues when internationalization resources are unavailable.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 27, 2025

Walkthrough

The setLocales function in the canvas container module has been updated to enhance error handling. The retrieval of the internationalization (i18n) instance now employs optional chaining to safely access the getI18n method. A new conditional check ensures that if the i18n instance is unavailable, the function exits early, preventing potential runtime errors while maintaining the existing logic for processing the messages object.

Changes

File Path Summary of Changes
packages/canvas/.../container.ts Modified setLocales to use optional chaining for accessing getI18n. Added a conditional check (if (!i18n) { return }) to avoid runtime errors.

Suggested reviewers

  • rhlin
  • hexqi

Poem

I'm a hopping coder in a land so bright,
Skipping across functions, day and night.
With optional chains, I leap with flair,
Avoiding errors with utmost care.
A bunny's delight as the code takes flight!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2f2d838 and e4b4f46.

📒 Files selected for processing (1)
  • packages/canvas/container/src/container.ts (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/canvas/container/src/container.ts
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: push-check

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the bug Something isn't working label Mar 27, 2025
@chilingling chilingling force-pushed the fix/getRendererErrBeforeCanvasInit branch from 0f2f8db to 2f2d838 Compare March 29, 2025 03:41
gene9831
gene9831 previously approved these changes Mar 29, 2025
Copy link
Collaborator

@gene9831 gene9831 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gene9831 gene9831 mentioned this pull request Apr 1, 2025
14 tasks
@chilingling chilingling force-pushed the fix/getRendererErrBeforeCanvasInit branch from 2f2d838 to e4b4f46 Compare April 8, 2025 12:20
@hexqi hexqi merged commit fc16170 into opentiny:develop Apr 8, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants