fix: VITE_CDN_TYPE should not be build on sub package build

[chilingling]

English | 简体中文

PR

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our Commit Message Guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)
• Built its own designer, fully self-validated

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

Background and solution

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

• Yes
• No

Other information

Summary by CodeRabbit

• New Features
  • Introduced a new CDN configuration option to enhance asset delivery management while preserving existing settings.

[coderabbitai]

Walkthrough

The changes update Vite configuration files in two packages by adding a new environment variable definition. Both configuration files now include an entry for 'import.meta.env.VITE_CDN_TYPE' alongside the pre-existing 'import.meta.env.VITE_API_MOCK' entry, expanding the set of environment variables available at build time.

Changes

File(s)	Change Summary
packages/common/vite.config.ts, packages/design-core/vite.config.js	Added new environment variable definition for 'import.meta.env.VITE_CDN_TYPE' alongside the existing API mock definition.

Possibly related PRs

• feat: support npmmirror cdn #1220: Added VITE_CDN_TYPE to Vite configurations in a related context.
• fix: fix some issue on preview page #568: Introduced a similar environment variable in Vite configuration files.

Suggested labels

bug, ready_for_review

Suggested reviewers

• hexqi
• rhlin

Poem

I’m a little rabbit with a hopping beat,
Config changes made my day so sweet.
New env variables line up in a row,
Helping our build process smoothly flow.
With carrots and code, off we go!
🥕🐇

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3739ce2 and e7b75a9.

📒 Files selected for processing (2)

• packages/common/vite.config.ts (1 hunks)
• packages/design-core/vite.config.js (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: push-check

🔇 Additional comments (2)

packages/common/vite.config.ts (1)

38-39: Added VITE_CDN_TYPE to environment variables definition.

The change adds VITE_CDN_TYPE to the list of environment variables in the Vite configuration's define object. This ensures that the CDN type environment variable is properly accessible during sub-package builds, which aligns with the PR objective to fix issues with VITE_CDN_TYPE in sub-package builds.

packages/design-core/vite.config.js (1)

38-39: Consistent environment variable definition across packages.

The same VITE_CDN_TYPE environment variable definition has been added to the design-core package, maintaining consistency with the common package. This ensures that both packages can access the CDN type configuration during their respective build processes.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.