Skip to content

fixed: When binding the data source, the State of the data source initialization and the original State were updated incorrectly, resulting in the ineffectiveness of the function. There is redundant and useless data in the Schema.#1208

Merged
chilingling merged 1 commit intoopentiny:developfrom
1degrees:fix/dataSourceBindingBug
Mar 10, 2025

Conversation

@1degrees
Copy link
Contributor

@1degrees 1degrees commented Mar 8, 2025

English | 简体中文

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Built its own designer, fully self-validated

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Background and solution

What is the current behavior?

修复: 数据源绑定时,将数据源初始化的State 和原有State错误更新,导致功能无效,Schame沉余无用数据

Issue Number: #1209

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • Refactor
    • Enhanced the mechanism for processing configuration updates to improve data organization and consistency during settings synchronization. This update strengthens the reliability of configuration changes without altering the visible interface.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 8, 2025

Walkthrough

The change modifies the VariableConfigurator component by updating the way the updateSchema function is invoked within the confirm method. Instead of spreading the pageSchema.state and adding a new property at the root level, the state properties are now nested under a new state key. This adjustment alters the structure of the object passed to updateSchema without affecting the overall logic.

Changes

File(s) Change Summary
packages/.../VariableConfigurator.vue Modified updateSchema call to nest existing state properties under a state key along with the new state entry.

Suggested labels

bug

Suggested reviewers

  • hexqi

Poem

I'm a nimble rabbit with a coding flair,
Hopping through updates with a joyful air.
Nesting states in a neat state bouquet,
Carrots and code brighten up the day.
Celebrate these changes with a hop and a smile!


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d0d9420 and 6fcb963.

📒 Files selected for processing (1)
  • packages/configurator/src/variable-configurator/VariableConfigurator.vue (1 hunks)

@chilingling
Copy link
Member

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


Next time you can add a gpg signature: https://docs.github.com/zh/authentication/managing-commit-signature-verification/telling-git-about-your-signing-key

@chilingling chilingling merged commit 100071c into opentiny:develop Mar 10, 2025
7 checks passed
1degrees added a commit to 1degrees/tiny-engine that referenced this pull request Mar 13, 2025
Co-authored-by: 张啸 <xiaozhang20@iflytek.com>
修复: 数据源绑定时,将数据源初始化的State 和原有State错误更新,导致功能无效,Schame沉余无用数据
1degrees added a commit to 1degrees/tiny-engine that referenced this pull request Mar 13, 2025
Co-authored-by: 张啸 <xiaozhang20@iflytek.com>
修复: 数据源绑定时,将数据源初始化的State 和原有State错误更新,导致功能无效,Schame沉余无用数据
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants