Skip to content

fix: page and block preview failure#1187

Merged
hexqi merged 2 commits intoopentiny:release/v2.3.0from
lichunn:fix/history-preview-0305
Mar 6, 2025
Merged

fix: page and block preview failure#1187
hexqi merged 2 commits intoopentiny:release/v2.3.0from
lichunn:fix/history-preview-0305

Conversation

@lichunn
Copy link
Collaborator

@lichunn lichunn commented Mar 5, 2025

English | 简体中文

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Built its own designer, fully self-validated

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Background and solution

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • New Features

    • Enhanced preview functionality for both pages and blocks by introducing conditional logic that tailors the preview experience based on context.
    • Integrated dynamic theme and page information into previews, ensuring a more accurate and context-aware display.
  • Refactor

    • Streamlined the retrieval and processing of preview parameters with asynchronous handling, leading to more efficient and cleaner previews.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 5, 2025

Walkthrough

This pull request updates several preview-related components. In the design core, a conditional early return is added to the page generation flow when the query parameter type is 'Block'. In the plugins and toolbars, preview functions now retrieve the theme state via a meta API and include additional page information. The page preview flow is also updated to use asynchronous ancestor retrieval from a composable. These changes adjust the control flow while maintaining the overall functionality of preview operations.

Changes

File(s) Change Summary
packages/design-core/.../Preview.vue Added a conditional block in getFamilyPages to check for queryParams.type === 'Block', push a new panel object (with properties including a generated panelValue), and return early, bypassing subsequent ancestor processing.
packages/plugins/block/src/BlockSetting.vue,
packages/plugins/page/.../PageHistory.vue,
packages/toolbars/preview/.../Main.vue
Modified preview functions to include theme retrieval via getMetaApi(META_SERVICE.ThemeSwitch) and pass additional pageInfo. In PageHistory.vue, previewHistory is now asynchronous and uses a new getFamily call for dynamic ancestor data, updating the parameter structure for preview operations.

Possibly related PRs

Suggested labels

ready_for_review, enhancement

Suggested reviewers

  • hexqi
  • chilingling

Poem

I'm just a rabbit in the code field,
Hopping through functions, my joy revealed.
With themes and async calls in sight,
Each refactor makes my ears feel light.
Cheers to the changes — a bouncy delight!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 41ea78d and 3956930.

📒 Files selected for processing (1)
  • packages/plugins/page/src/PageHistory.vue (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/plugins/page/src/PageHistory.vue
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: push-check

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the bug Something isn't working label Mar 5, 2025
@hexqi hexqi merged commit 9585991 into opentiny:release/v2.3.0 Mar 6, 2025
2 checks passed
SonyLeo pushed a commit to SonyLeo/tiny-engine that referenced this pull request Mar 7, 2025
* fix: 修复页面区块预览失效问题

* fix:fix review
SonyLeo pushed a commit to SonyLeo/tiny-engine that referenced this pull request Mar 7, 2025
* fix: 修复页面区块预览失效问题

* fix:fix review
1degrees pushed a commit to 1degrees/tiny-engine that referenced this pull request Mar 13, 2025
* fix: 修复页面区块预览失效问题

* fix:fix review
@coderabbitai coderabbitai bot mentioned this pull request Mar 29, 2025
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants