fix: The tab supports editing the title and name#1157
Closed
xuanlid wants to merge 2 commits intoopentiny:developfrom
Closed
fix: The tab supports editing the title and name#1157xuanlid wants to merge 2 commits intoopentiny:developfrom
xuanlid wants to merge 2 commits intoopentiny:developfrom
Conversation
Contributor
WalkthroughThis pull request updates the configurator component by introducing new conditional rendering for the TinyTabs component. It adds a header with two div elements displaying "页签标题" and "页签值", a Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant CC as ContainerConfigurator
participant UI as UI Renderer
U->>CC: Load component
CC->>UI: Check if component is TinyTabs
alt TinyTabs Component Active
UI->>UI: Render header with "页签标题" and "页签值"
UI->>UI: Render tiny-input for data.props.name
UI->>UI: Render button with SVG icon
end
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
hexqi
reviewed
Mar 17, 2025
| @@ -1,10 +1,19 @@ | |||
| <template> | |||
| <div> | |||
| <div v-if="componentName === 'TinyTabs'" class="tabs-header"> | |||
Collaborator
There was a problem hiding this comment.
ContainerConfigurator定位应该是一个通用的设置器组件，需要通过传入配置的方式来实现，不能与TinyTabs组件相绑定
hexqi
reviewed
Mar 17, 2025
| v-if="componentName === 'TinyTabs'" | ||
| v-model="data.props.name" | ||
| @update:modelValue="onTitleUpdate(data)" | ||
| /> |
Collaborator
There was a problem hiding this comment.
有个Bug: 在输入框无法鼠标选中文本，因为会触发拖动，应该只有图标可以拖动
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
English | 简体中文
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
Background and solution
Fixes #1106
标签页组件可以配置tab title 和 tab name
tab title —>页签名
tab name —>页签ID
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit
Summary by CodeRabbit
New Features
Style