fix(canvas/render): fix switching between top pages in standalone view mode, cssScope not updated and entry point pageContext active error

[rhlin]

English | 简体中文

PR

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our Commit Message Guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)
• Built its own designer, fully self-validated

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

Background and solution

单页模式下， 切换页面后变成不可编辑并且css没有渲染上

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

• Yes
• No

Other information

Summary by CodeRabbit

• Refactor
  • Updated page context management logic to simplify state handling
  • Introduced CSS scope ID generation for pages
  • Removed dependency on prop-based page activation

[coderabbitai]

Walkthrough

The pull request modifies the RenderMain.ts file in the canvas render package, specifically altering how pageContext properties are set. The changes replace the previous conditional logic for setting pageId with a direct assignment from pageIdFromPath. A new method call setCssScopeId() is introduced to set a CSS scope identifier based on the page ID. The modification simplifies the page context initialization process and removes the previous conditional handling of the active property.

Changes

File	Change Summary
packages/canvas/render/src/RenderMain.ts	- Replaced conditional pageContext.pageId assignment with direct pageIdFromPath assignment - Removed pageContext.active property setting - Added pageContext.setCssScopeId() method call with dynamic CSS scope identifier

Suggested labels

bug, ready_for_review, refactor-main

Suggested reviewers

• chilingling
• hexqi

Possibly related PRs

• fix: switch page or block should clear selection #992: Modifies importSchema function to clear selections after schema import, related to canvas context state management

Poem

🐰 In the realm of render and page,
A rabbit hops through code's new stage,
PageContext dances, simple and bright,
CSS scopes now set just right!
Refactoring magic, clean and neat,
A coding ballet, oh so sweet! 🎨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2e16346 and eb4f06a.

📒 Files selected for processing (1)

• packages/canvas/render/src/RenderMain.ts (1 hunks)

🔇 Additional comments (1)

packages/canvas/render/src/RenderMain.ts (1)

152-153: LGTM! Changes align with fixing page switching issues.

The changes correctly standardize the page ID source and ensure proper CSS scope updates during history changes.

Verify removal of active state update.

The active state is no longer updated during history changes. Please verify this doesn't affect page activation in other scenarios.

Consider adding a comment.

Add a comment explaining why we're using pageIdFromPath directly instead of falling back to props.pageId:

        const pageIdFromPath = getController().getBaseInfo().pageId
+       // Always use pageId from controller to ensure consistent page context during navigation
        pageContext.pageId = pageIdFromPath
        pageContext.setCssScopeId(`data-te-page-${pageContext.pageId}`)

✅ Verification successful

Active state update removal is safe ✅

The active state is properly managed through props and entry status in the main component initialization. Removing the redundant update from history change handler doesn't affect the page activation logic.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for other occurrences of pageContext.active assignments
# to ensure we haven't missed any critical update points
rg "pageContext.active\s*=" --type ts

Length of output: 152

Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.