Skip to content

Technical debt#3274

Merged
basfroman merged 20 commits intostagingfrom
feat/roman/technical-debt
Feb 25, 2026
Merged

Technical debt#3274
basfroman merged 20 commits intostagingfrom
feat/roman/technical-debt

Conversation

@basfroman
Copy link
Collaborator

@basfroman basfroman commented Feb 25, 2026 •
edited
Loading

  • fix flaky e2e test
  • fix mypy issues in subtensor.py
  • consistent update for async_subtensor.py

@basfroman basfroman self-assigned this Feb 25, 2026
@github-actions
Copy link

github-actions bot commented Feb 25, 2026

Bittensor SDK virtual environment sizes by Python version:

Python 3.10: 165 MB
Python 3.11: 179 MB
Python 3.12: 174 MB
Python 3.13: 173 MB

2 similar comments
@github-actions
Copy link

github-actions bot commented Feb 25, 2026

Bittensor SDK virtual environment sizes by Python version:

Python 3.10: 165 MB
Python 3.11: 179 MB
Python 3.12: 174 MB
Python 3.13: 173 MB

@github-actions
Copy link

github-actions bot commented Feb 25, 2026

Bittensor SDK virtual environment sizes by Python version:

Python 3.10: 165 MB
Python 3.11: 179 MB
Python 3.12: 174 MB
Python 3.13: 173 MB

@basfroman basfroman changed the base branch from master to staging February 25, 2026 06:14
@basfroman basfroman requested a review from a team February 25, 2026 06:42
thewhaleking
thewhaleking reviewed Feb 25, 2026
View reviewed changes
Copy link
Contributor

@thewhaleking thewhaleking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleaner code suggestions.

WIll likely need to run ruff after applying

thewhaleking
thewhaleking reviewed Feb 25, 2026
View reviewed changes
Copy link
Contributor

@thewhaleking thewhaleking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleaner code suggestions.

WIll likely need to run ruff after applying

basfroman and others added 12 commits February 25, 2026 00:43
@basfroman
mypy
121f707
@basfroman @thewhaleking
Update bittensor/core/subtensor.py
501a3bd 
Co-authored-by: BD Himes <37844818+thewhaleking@users.noreply.github.com>
@basfroman @thewhaleking
Update bittensor/core/subtensor.py
1c370cb 
Co-authored-by: BD Himes <37844818+thewhaleking@users.noreply.github.com>
@basfroman @thewhaleking
Update bittensor/core/async_subtensor.py
4e2a574 
Co-authored-by: BD Himes <37844818+thewhaleking@users.noreply.github.com>
@basfroman @thewhaleking
Update bittensor/core/async_subtensor.py
b5ca8f5 
Co-authored-by: BD Himes <37844818+thewhaleking@users.noreply.github.com>
@basfroman @thewhaleking
Update bittensor/core/async_subtensor.py
ecf4582 
Co-authored-by: BD Himes <37844818+thewhaleking@users.noreply.github.com>
@basfroman @thewhaleking
Update bittensor/core/async_subtensor.py
d9f0fe9 
Co-authored-by: BD Himes <37844818+thewhaleking@users.noreply.github.com>
@basfroman @thewhaleking
Update bittensor/core/async_subtensor.py
d81611a 
Co-authored-by: BD Himes <37844818+thewhaleking@users.noreply.github.com>
@basfroman @thewhaleking
Update bittensor/core/subtensor.py
12bfb14 
Co-authored-by: BD Himes <37844818+thewhaleking@users.noreply.github.com>
@basfroman @thewhaleking
Update bittensor/core/subtensor.py
b2426f3 
Co-authored-by: BD Himes <37844818+thewhaleking@users.noreply.github.com>
@basfroman @thewhaleking
Update bittensor/core/subtensor.py
9911485 
Co-authored-by: BD Himes <37844818+thewhaleking@users.noreply.github.com>
@basfroman @thewhaleking
Update bittensor/core/async_subtensor.py
d769f4a 
Co-authored-by: BD Himes <37844818+thewhaleking@users.noreply.github.com>
basfroman and others added 2 commits February 25, 2026 01:09
@basfroman @thewhaleking
Apply suggestions from code review
97b29c3 
Co-authored-by: BD Himes <37844818+thewhaleking@users.noreply.github.com>
@basfroman
typo from review
93642ad
thewhaleking
thewhaleking approved these changes Feb 25, 2026
View reviewed changes
Copy link
Contributor

@thewhaleking thewhaleking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@basfroman basfroman merged commit 1e3f933 into staging Feb 25, 2026
658 checks passed
@basfroman basfroman deleted the feat/roman/technical-debt branch February 25, 2026 18:14
@ibraheem-abe ibraheem-abe mentioned this pull request Mar 3, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thewhaleking thewhaleking thewhaleking approved these changes

Assignees

@basfroman basfroman

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@basfroman @thewhaleking