Skip to content

OCPBUGS-32927: Bump OVS version to 3.3.#1495

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
igsilya:ovs-3.3
May 7, 2024
Merged

OCPBUGS-32927: Bump OVS version to 3.3.#1495
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
igsilya:ovs-3.3

Conversation

@igsilya
Copy link
Copy Markdown
Contributor

@igsilya igsilya commented Apr 24, 2024

Open vSwitch 3.3 is going to be a new LTS version. It contains performance improvements and features required for future releases of OVN.

ovn-kubernetes container image is moving to this version as well, and it's better to keep them in sync.

ovn-kubernetes counterpart: openshift/ovn-kubernetes#2142

Open vSwitch 3.3 is going to be a new LTS version.  It contains
performance improvements and features required for future releases
of OVN.

ovn-kubernetes container image is moving to this version as well,
and it's better to keep them in sync.

Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 24, 2024
@igsilya igsilya changed the title Bump OVS version to 3.3. OCPBUGS-32927: Bump OVS version to 3.3. Apr 24, 2024
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Apr 24, 2024
@openshift-ci-robot
Copy link
Copy Markdown

@igsilya: This pull request references Jira Issue OCPBUGS-32927, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @mike-nguyen

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Open vSwitch 3.3 is going to be a new LTS version. It contains performance improvements and features required for future releases of OVN.

ovn-kubernetes container image is moving to this version as well, and it's better to keep them in sync.

ovn-kubernetes counterpart: openshift/ovn-kubernetes#2142

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@igsilya igsilya marked this pull request as ready for review April 24, 2024 17:08
@openshift-ci openshift-ci bot requested a review from mike-nguyen April 24, 2024 17:08
@openshift-ci openshift-ci bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Apr 24, 2024
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 24, 2024

Hi @igsilya. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from gursewak1997 April 24, 2024 17:15
@dceara
Copy link
Copy Markdown

dceara commented Apr 24, 2024

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 24, 2024
@jlebon
Copy link
Copy Markdown
Member

jlebon commented Apr 25, 2024

Patch itself LGTM.
/approve

Will let @dcbw sanity-check it since historically he's been the one bumping OVS.

/assign dcbw

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 25, 2024
@igsilya
Copy link
Copy Markdown
Contributor Author

igsilya commented Apr 26, 2024

@jlebon Hi. I don't think Dan will be checking this PR. See the email.

Copy link
Copy Markdown

@tssurya tssurya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm from ocp sdn side

@tssurya
Copy link
Copy Markdown

tssurya commented Apr 26, 2024

/hold
till ovs container bump lands

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 26, 2024
@jlebon
Copy link
Copy Markdown
Member

jlebon commented Apr 26, 2024

/lgtm

Feel free to drop the hold when ready.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 26, 2024
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: igsilya, jlebon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@igsilya
Copy link
Copy Markdown
Contributor Author

igsilya commented May 6, 2024

All the container changes have landed last week. Did another round of conformance tests on a manually upgraded cluster with this change and it looked good.

/remove-hold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 6, 2024
@openshift-ci-robot
Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD d682302 and 2 for PR HEAD 92e4ef2 in total

@igsilya
Copy link
Copy Markdown
Contributor Author

igsilya commented May 6, 2024

/retest-required

@igsilya
Copy link
Copy Markdown
Contributor Author

igsilya commented May 6, 2024

error: Installing packages: Failed to parse selector: nss-altfiles
failed to execute cmd-fetch: exit status 1

Not sure why this is failing (didn't fail before).

@jlebon do you have ideas on why this can be?

@igsilya
Copy link
Copy Markdown
Contributor Author

igsilya commented May 6, 2024

Looks like the issue is affecting other PRs as well, i.e. not related to this one.

@jlebon jlebon unassigned dcbw May 6, 2024
@jlebon
Copy link
Copy Markdown
Member

jlebon commented May 6, 2024

error: Installing packages: Failed to parse selector: nss-altfiles
failed to execute cmd-fetch: exit status 1

I hit this locally too and then updated my repo files to use the 9.4 GA repos instead of beta. I suspect the in-cluster mirrors might still have beta content.

@travier
Copy link
Copy Markdown
Member

travier commented May 7, 2024

CI fixes in openshift/release#51750

@igsilya
Copy link
Copy Markdown
Contributor Author

igsilya commented May 7, 2024

/retest-required

(I wonder how fast changes propagate.)

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented May 7, 2024

@igsilya: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 2c34a70 into openshift:master May 7, 2024
@openshift-ci-robot
Copy link
Copy Markdown

@igsilya: Jira Issue OCPBUGS-32927: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-32927 has been moved to the MODIFIED state.

Details

In response to this:

Open vSwitch 3.3 is going to be a new LTS version. It contains performance improvements and features required for future releases of OVN.

ovn-kubernetes container image is moving to this version as well, and it's better to keep them in sync.

ovn-kubernetes counterpart: openshift/ovn-kubernetes#2142

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

igsilya added a commit to igsilya/microshift that referenced this pull request May 13, 2024
4.16 ovn-kubernetes and RHCOS are both moved to OVS 3.3:
  - openshift/ovn-kubernetes#2142
  - openshift/os#1495

MicroShift should be kept in sync.

Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants