Skip to content

WINC-1777: register windows-machine-config-operator OTE binary#30945

Open
weinliu wants to merge 1 commit intoopenshift:mainfrom
weinliu:WINC-1777-register-wmco-ote
Open

WINC-1777: register windows-machine-config-operator OTE binary#30945
weinliu wants to merge 1 commit intoopenshift:mainfrom
weinliu:WINC-1777-register-wmco-ote

Conversation

@weinliu
Copy link
Copy Markdown

@weinliu weinliu commented Mar 31, 2026

Register wmco-tests-ext.gz in the extension registry so that openshift-tests can discover and invoke WINC OTE tests automatically in Prow jobs.

Related: openshift/windows-machine-config-operator#3874

Jira: WINC-1777

Register wmco-tests-ext.gz in the extension registry so that
openshift-tests can discover and invoke WINC OTE tests automatically
in Prow periodic/presubmit jobs.

Related: openshift/windows-machine-config-operator#3874
@openshift-ci-robot
Copy link
Copy Markdown

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 31, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Mar 31, 2026

@weinliu: This pull request references WINC-1777 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Register wmco-tests-ext.gz in the extension registry so that openshift-tests can discover and invoke WINC OTE tests automatically in Prow jobs.

Related: openshift/windows-machine-config-operator#3874

Jira: WINC-1777

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from p0lyn0mial and sjenning March 31, 2026 20:51
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 31, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: weinliu
Once this PR has been reviewed and has the lgtm label, please assign sosiouxme for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 31, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 011c9e7d-05cf-48dc-9c39-11b58e3e7eb4

📥 Commits

Reviewing files that changed from the base of the PR and between a85a0eb and d1847ea.

📒 Files selected for processing (1)
  • pkg/test/extensions/binary.go

Walkthrough

Added a TestBinary entry to the extensionBinaries registry for the windows-machine-config-operator image tag, mapping it to an external binary artifact path. This extends the set of release payload extension binaries available for discovery and extraction operations.

Changes

Cohort / File(s) Summary
Extension Binaries Registry
pkg/test/extensions/binary.go
Added a new TestBinary entry for windows-machine-config-operator image tag that maps to the /usr/bin/wmco-tests-ext.gz external binary artifact path.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.11.4)

Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions
The command is terminated due to an error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci-robot
Copy link
Copy Markdown

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@weinliu
Copy link
Copy Markdown
Author

weinliu commented Mar 31, 2026

Closing for now — the WMCO binary is not yet in the CI release payload (openshift/windows-machine-config-operator#3874 not yet merged). Will re-open once the binary is available in the image to avoid breaking MicroShift conformance tests.

@weinliu weinliu closed this Mar 31, 2026
@weinliu weinliu reopened this Apr 2, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 2, 2026

@weinliu: This pull request references WINC-1777 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Register wmco-tests-ext.gz in the extension registry so that openshift-tests can discover and invoke WINC OTE tests automatically in Prow jobs.

Related: openshift/windows-machine-config-operator#3874

Jira: WINC-1777

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Copy Markdown

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-microshift
/test e2e-aws-ovn-microshift-serial
/test e2e-aws-ovn-serial-1of2
/test e2e-aws-ovn-serial-2of2
/test e2e-gcp-csi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi

@weinliu
Copy link
Copy Markdown
Author

weinliu commented Apr 2, 2026

/retest

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 2, 2026

@weinliu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ovn d1847ea link true /test e2e-gcp-ovn
ci/prow/e2e-aws-ovn-microshift d1847ea link true /test e2e-aws-ovn-microshift
ci/prow/e2e-aws-ovn-microshift-serial d1847ea link true /test e2e-aws-ovn-microshift-serial
ci/prow/e2e-aws-ovn-serial-2of2 d1847ea link true /test e2e-aws-ovn-serial-2of2
ci/prow/e2e-vsphere-ovn d1847ea link true /test e2e-vsphere-ovn
ci/prow/e2e-gcp-csi d1847ea link true /test e2e-gcp-csi
ci/prow/e2e-vsphere-ovn-upi d1847ea link true /test e2e-vsphere-ovn-upi
ci/prow/e2e-aws-csi d1847ea link true /test e2e-aws-csi
ci/prow/e2e-gcp-ovn-upgrade d1847ea link true /test e2e-gcp-ovn-upgrade
ci/prow/e2e-aws-ovn-fips d1847ea link true /test e2e-aws-ovn-fips
ci/prow/e2e-aws-ovn-serial-1of2 d1847ea link true /test e2e-aws-ovn-serial-1of2
ci/prow/e2e-metal-ipi-ovn-ipv6 d1847ea link true /test e2e-metal-ipi-ovn-ipv6

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-trt
Copy link
Copy Markdown

openshift-trt bot commented Apr 3, 2026

Job Failure Risk Analysis for sha: d1847ea

Job Name Failure Risk
pull-ci-openshift-origin-main-e2e-aws-csi IncompleteTests
Tests for this run (80) are below the historical average (2092): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-aws-ovn-fips IncompleteTests
Tests for this run (29) are below the historical average (3201): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-aws-ovn-microshift IncompleteTests
Tests for this run (29) are below the historical average (1858): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-aws-ovn-microshift-serial IncompleteTests
Tests for this run (21) are below the historical average (988): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-aws-ovn-serial-1of2 IncompleteTests
Tests for this run (80) are below the historical average (2089): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-aws-ovn-serial-2of2 IncompleteTests
Tests for this run (80) are below the historical average (2102): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-gcp-csi IncompleteTests
Tests for this run (78) are below the historical average (2144): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-gcp-ovn IncompleteTests
Tests for this run (78) are below the historical average (3702): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-gcp-ovn-upgrade IncompleteTests
Tests for this run (78) are below the historical average (2118): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-metal-ipi-ovn-ipv6 IncompleteTests
Tests for this run (73) are below the historical average (2742): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-vsphere-ovn IncompleteTests
Tests for this run (75) are below the historical average (3789): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)
pull-ci-openshift-origin-main-e2e-vsphere-ovn-upi IncompleteTests
Tests for this run (75) are below the historical average (3246): IncompleteTests (not enough tests ran to make a reasonable risk analysis; this could be due to infra, installation, or upgrade problems)

@weinliu
Copy link
Copy Markdown
Author

weinliu commented Apr 3, 2026

Hi @smg247 and @lihongan — would you mind taking a look at this PR when you get a chance?

This registers the WMCO OTE extension binary (wmco-tests-ext.gz) following the same pattern as other components. The e2e failures are due to a payload timing issue (the new WMCO image containing the binary wasn't yet included in the CI payload at the time the tests ran) — not related to the code change itself.

Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants