SDN-4783: Add e2e tests for NetworkDiagnosticsConfig featuregate by kyrtapz · Pull Request #28719 · openshift/origin

kyrtapz · 2024-04-17T11:14:12Z

This is blocked by openshift/cluster-network-operator#2339

openshift-ci-robot · 2024-04-17T11:14:15Z

@kyrtapz: This pull request references SDN-4783 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

Details

In response to this:

This is blocked by openshift/cluster-network-operator#2339

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2024-04-17T11:14:18Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

ricky-rav

Overall looks good, I left a few questions.

test/extended/networking/network_diagnostics.go

ricky-rav · 2024-04-18T15:43:27Z

/lgtm
Thanks, @kyrtapz!

trozet · 2024-04-23T17:51:45Z

/approve

kyrtapz · 2024-04-24T10:28:28Z

/test images

kyrtapz · 2024-04-24T10:49:52Z

CI seems to be back
/retest

kyrtapz · 2024-04-24T12:07:30Z

/test images

kyrtapz · 2024-04-24T15:24:06Z

/test images

kyrtapz · 2024-04-24T15:44:12Z

@dgoodwin are you ok with the cliet-go bump? It looks like the bot needs your blessing

kyrtapz · 2024-04-25T07:18:36Z

/retest

kyrtapz · 2024-04-25T08:10:37Z

/test ?

openshift-ci · 2024-04-25T08:11:20Z

@kyrtapz: The following commands are available to trigger required jobs:

/test e2e-aws-jenkins
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-image-registry
/test e2e-aws-ovn-serial
/test e2e-gcp-ovn
/test e2e-gcp-ovn-builds
/test e2e-gcp-ovn-image-ecosystem
/test e2e-gcp-ovn-upgrade
/test e2e-metal-ipi-ovn-ipv6
/test images
/test lint
/test unit
/test verify
/test verify-deps

The following commands are available to trigger optional jobs:

/test 4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade-rollback
/test e2e-agnostic-ovn-cmd
/test e2e-aws
/test e2e-aws-csi
/test e2e-aws-disruptive
/test e2e-aws-etcd-recovery
/test e2e-aws-multitenant
/test e2e-aws-ovn
/test e2e-aws-ovn-cgroupsv2
/test e2e-aws-ovn-etcd-scaling
/test e2e-aws-ovn-kubevirt
/test e2e-aws-ovn-single-node
/test e2e-aws-ovn-single-node-serial
/test e2e-aws-ovn-single-node-upgrade
/test e2e-aws-ovn-upgrade
/test e2e-aws-ovn-upi
/test e2e-aws-proxy
/test e2e-azure
/test e2e-azure-ovn-etcd-scaling
/test e2e-baremetalds-kubevirt
/test e2e-gcp-csi
/test e2e-gcp-disruptive
/test e2e-gcp-fips-serial
/test e2e-gcp-ovn-etcd-scaling
/test e2e-gcp-ovn-rt-upgrade
/test e2e-gcp-ovn-techpreview
/test e2e-gcp-ovn-techpreview-serial
/test e2e-metal-ipi-ovn-dualstack
/test e2e-metal-ipi-ovn-dualstack-local-gateway
/test e2e-metal-ipi-sdn
/test e2e-metal-ipi-serial
/test e2e-metal-ipi-serial-ovn-ipv6
/test e2e-metal-ipi-virtualmedia
/test e2e-openstack-ovn
/test e2e-openstack-serial
/test e2e-vsphere
/test e2e-vsphere-ovn-dualstack-primaryv6
/test e2e-vsphere-ovn-etcd-scaling
/test okd-e2e-gcp

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-origin-master-e2e-agnostic-ovn-cmd
pull-ci-openshift-origin-master-e2e-aws-csi
pull-ci-openshift-origin-master-e2e-aws-ovn-cgroupsv2
pull-ci-openshift-origin-master-e2e-aws-ovn-fips
pull-ci-openshift-origin-master-e2e-aws-ovn-serial
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-serial
pull-ci-openshift-origin-master-e2e-aws-ovn-single-node-upgrade
pull-ci-openshift-origin-master-e2e-aws-ovn-upgrade
pull-ci-openshift-origin-master-e2e-gcp-csi
pull-ci-openshift-origin-master-e2e-gcp-ovn
pull-ci-openshift-origin-master-e2e-gcp-ovn-builds
pull-ci-openshift-origin-master-e2e-gcp-ovn-rt-upgrade
pull-ci-openshift-origin-master-e2e-gcp-ovn-upgrade
pull-ci-openshift-origin-master-e2e-metal-ipi-ovn-ipv6
pull-ci-openshift-origin-master-e2e-metal-ipi-sdn
pull-ci-openshift-origin-master-e2e-openstack-ovn
pull-ci-openshift-origin-master-images
pull-ci-openshift-origin-master-lint
pull-ci-openshift-origin-master-unit
pull-ci-openshift-origin-master-verify
pull-ci-openshift-origin-master-verify-deps

Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kyrtapz · 2024-04-25T08:11:51Z

/test e2e-gcp-ovn-techpreview
/test e2e-gcp-ovn-techpreview-serial

dgoodwin · 2024-04-25T11:05:57Z

/approve

openshift-trt-bot · 2024-05-07T10:06:12Z

Job Failure Risk Analysis for sha: 6d1ff92

Job Name	Failure Risk
pull-ci-openshift-origin-master-e2e-gcp-ovn-techpreview-serial	Low [sig-arch] events should not repeat pathologically This test has passed 25.00% of 4 runs on jobs ['periodic-ci-openshift-release-master-ci-4.17-e2e-gcp-ovn-techpreview-serial'] in the last 14 days. Open Bugs CSO generates excessive progressing condition events Excessive TopologyAwareHintsDisabled events due to service/dns-default with topology aware hints activated. 4.16 testcase failing on power "[sig-arch] events should not repeat pathologically for ns/openshift-cloud-controller-manager" Excessive TopologyAwareHintsDisabled events due to service/dns-default with topology aware hints activated. Excessive TopologyAwareHintsDisabled events due to service/dns-default with topology aware hints activated. "k8s.ovn.org/node-chassis-id annotation not found" event causing CI failures

ricky-rav · 2024-05-07T13:22:10Z

/lgtm

dgoodwin · 2024-05-07T13:37:55Z

/override ci/prow/e2e-gcp-ovn-builds

openshift-ci · 2024-05-07T13:38:12Z

@dgoodwin: Overrode contexts on behalf of dgoodwin: ci/prow/e2e-gcp-ovn-builds

Details

In response to this:

/override ci/prow/e2e-gcp-ovn-builds

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kyrtapz · 2024-05-07T15:04:51Z

/test e2e-metal-ipi-ovn-ipv6

kyrtapz · 2024-05-07T16:50:30Z

/retest-required

openshift-trt-bot · 2024-05-07T20:16:02Z

Job Failure Risk Analysis for sha: 6d1ff92

Job Name	Failure Risk
pull-ci-openshift-origin-master-e2e-gcp-ovn-techpreview-serial	Low [sig-arch] events should not repeat pathologically This test has passed 25.00% of 4 runs on jobs ['periodic-ci-openshift-release-master-ci-4.17-e2e-gcp-ovn-techpreview-serial'] in the last 14 days. Open Bugs CSO generates excessive progressing condition events Excessive TopologyAwareHintsDisabled events due to service/dns-default with topology aware hints activated. 4.16 testcase failing on power "[sig-arch] events should not repeat pathologically for ns/openshift-cloud-controller-manager" Excessive TopologyAwareHintsDisabled events due to service/dns-default with topology aware hints activated. Excessive TopologyAwareHintsDisabled events due to service/dns-default with topology aware hints activated. "k8s.ovn.org/node-chassis-id annotation not found" event causing CI failures

openshift-ci-robot · 2024-05-07T21:19:22Z

/retest-required

Remaining retests: 0 against base HEAD e753fc9 and 2 for PR HEAD 6d1ff92 in total

openshift-trt-bot · 2024-05-07T23:21:25Z

Job Failure Risk Analysis for sha: 6d1ff92

Job Name	Failure Risk
pull-ci-openshift-origin-master-e2e-gcp-ovn-techpreview-serial	Low [sig-arch] events should not repeat pathologically This test has passed 25.00% of 4 runs on jobs ['periodic-ci-openshift-release-master-ci-4.17-e2e-gcp-ovn-techpreview-serial'] in the last 14 days. Open Bugs CSO generates excessive progressing condition events Excessive TopologyAwareHintsDisabled events due to service/dns-default with topology aware hints activated. 4.16 testcase failing on power "[sig-arch] events should not repeat pathologically for ns/openshift-cloud-controller-manager" Excessive TopologyAwareHintsDisabled events due to service/dns-default with topology aware hints activated. Excessive TopologyAwareHintsDisabled events due to service/dns-default with topology aware hints activated. "k8s.ovn.org/node-chassis-id annotation not found" event causing CI failures

openshift-trt-bot · 2024-05-08T00:06:05Z

Job Failure Risk Analysis for sha: 6d1ff92

Job Name	Failure Risk
pull-ci-openshift-origin-master-e2e-gcp-ovn-techpreview-serial	Low [sig-arch] events should not repeat pathologically This test has passed 25.00% of 4 runs on jobs ['periodic-ci-openshift-release-master-ci-4.17-e2e-gcp-ovn-techpreview-serial'] in the last 14 days. Open Bugs CSO generates excessive progressing condition events Excessive TopologyAwareHintsDisabled events due to service/dns-default with topology aware hints activated. 4.16 testcase failing on power "[sig-arch] events should not repeat pathologically for ns/openshift-cloud-controller-manager" Excessive TopologyAwareHintsDisabled events due to service/dns-default with topology aware hints activated. Excessive TopologyAwareHintsDisabled events due to service/dns-default with topology aware hints activated. "k8s.ovn.org/node-chassis-id annotation not found" event causing CI failures

openshift-ci-robot · 2024-05-08T00:37:04Z

/retest-required

Remaining retests: 0 against base HEAD 574269c and 1 for PR HEAD 6d1ff92 in total

kyrtapz · 2024-05-08T06:47:37Z

/retest-required

Signed-off-by: Patryk Diak <pdiak@redhat.com>

kyrtapz · 2024-05-08T06:59:40Z

Had to re-vendor after rebasing to master.

kyrtapz · 2024-05-08T06:59:51Z

/test e2e-gcp-ovn-techpreview-serial

jcaamano · 2024-05-08T08:49:27Z

/lgtm

openshift-ci · 2024-05-08T08:50:09Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, jcaamano, kyrtapz, ricky-rav, trozet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [dgoodwin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

kyrtapz · 2024-05-08T09:35:12Z

/test e2e-gcp-ovn-builds

kyrtapz · 2024-05-08T11:44:51Z

/tide refresh

openshift-ci · 2024-05-08T15:43:52Z

@kyrtapz: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-ovn-techpreview-serial	`432f8e5`	link	false	`/test e2e-gcp-ovn-techpreview-serial`
ci/prow/e2e-openstack-ovn	`432f8e5`	link	false	`/test e2e-openstack-ovn`
ci/prow/e2e-aws-ovn-single-node-serial	`432f8e5`	link	false	`/test e2e-aws-ovn-single-node-serial`
ci/prow/e2e-aws-ovn-single-node	`432f8e5`	link	false	`/test e2e-aws-ovn-single-node`
ci/prow/e2e-metal-ipi-sdn	`432f8e5`	link	false	`/test e2e-metal-ipi-sdn`
ci/prow/e2e-aws-ovn-single-node-upgrade	`432f8e5`	link	false	`/test e2e-aws-ovn-single-node-upgrade`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 17, 2024

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 17, 2024

openshift-ci bot added the vendor-update Touching vendor dir or related files label Apr 17, 2024

ricky-rav reviewed Apr 18, 2024

View reviewed changes

test/extended/networking/network_diagnostics.go Show resolved Hide resolved

test/extended/networking/network_diagnostics.go Show resolved Hide resolved

test/extended/networking/network_diagnostics.go Show resolved Hide resolved

kyrtapz force-pushed the network_diagnostics branch from 3a89023 to 9f05e0a Compare April 18, 2024 15:33

openshift-ci bot assigned ricky-rav Apr 18, 2024

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2024

trozet approved these changes Apr 23, 2024

View reviewed changes

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 23, 2024

kyrtapz force-pushed the network_diagnostics branch from 9f05e0a to fb53aae Compare April 24, 2024 09:19

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2024

kyrtapz marked this pull request as ready for review April 24, 2024 09:19

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 24, 2024

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 24, 2024

openshift-ci bot requested review from deads2k and knobunc April 24, 2024 09:21

kyrtapz mentioned this pull request May 7, 2024

SDN-4821: Add an optional TechPreview serial job to CNO openshift/release#51752

Merged

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2024

kyrtapz added 2 commits May 8, 2024 08:57

Bump github.com/openshift/client-go

17e3205

Signed-off-by: Patryk Diak <pdiak@redhat.com>

NetworkDiagnosticsConfig tests

432f8e5

Signed-off-by: Patryk Diak <pdiak@redhat.com>

kyrtapz force-pushed the network_diagnostics branch from 6d1ff92 to 432f8e5 Compare May 8, 2024 06:58

openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 8, 2024

openshift-ci bot assigned jcaamano May 8, 2024

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 8, 2024

openshift-merge-bot bot merged commit 9d46920 into openshift:master May 8, 2024

This was referenced May 10, 2024

SDN-4600: Add NetworkDiagnosticsConfig to the default featureset openshift/api#1886

Merged

CFE-853: e2e test case for DNSNameResolver and EgressFirewall integration #28683

Merged

Conversation

kyrtapz commented Apr 17, 2024

Uh oh!

openshift-ci-robot commented Apr 17, 2024 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Apr 17, 2024

Uh oh!

ricky-rav left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ricky-rav commented Apr 18, 2024

Uh oh!

trozet commented Apr 23, 2024

Uh oh!

kyrtapz commented Apr 24, 2024

Uh oh!

kyrtapz commented Apr 24, 2024

Uh oh!

kyrtapz commented Apr 24, 2024

Uh oh!

kyrtapz commented Apr 24, 2024

Uh oh!

kyrtapz commented Apr 24, 2024

Uh oh!

kyrtapz commented Apr 25, 2024

Uh oh!

kyrtapz commented Apr 25, 2024

Uh oh!

openshift-ci bot commented Apr 25, 2024

Uh oh!

kyrtapz commented Apr 25, 2024

Uh oh!

dgoodwin commented Apr 25, 2024

Uh oh!

openshift-trt-bot commented May 7, 2024

Uh oh!

ricky-rav commented May 7, 2024

Uh oh!

dgoodwin commented May 7, 2024

Uh oh!

openshift-ci bot commented May 7, 2024

Uh oh!

kyrtapz commented May 7, 2024

Uh oh!

kyrtapz commented May 7, 2024

Uh oh!

openshift-trt-bot commented May 7, 2024

Uh oh!

openshift-ci-robot commented May 7, 2024

Uh oh!

openshift-trt-bot commented May 7, 2024

Uh oh!

openshift-trt-bot commented May 8, 2024

Uh oh!

openshift-ci-robot commented May 8, 2024

Uh oh!

kyrtapz commented May 8, 2024

Uh oh!

kyrtapz commented May 8, 2024

Uh oh!

kyrtapz commented May 8, 2024

Uh oh!

jcaamano commented May 8, 2024

Uh oh!

openshift-ci bot commented May 8, 2024

Uh oh!

kyrtapz commented May 8, 2024

Uh oh!

kyrtapz commented May 8, 2024

Uh oh!

openshift-ci bot commented May 8, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

openshift-ci-robot commented Apr 17, 2024 •

edited by openshift-ci bot

Loading