Skip to content

NO-JIRA: Fix oc builds on Mac OS X Apple Silicon machines #2246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tchap wants to merge 1 commit into
base: main
Choose a base branch
from
Open

NO-JIRA: Fix oc builds on Mac OS X Apple Silicon machines #2246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,7 @@ require (
sigs.k8s.io/structured-merge-diff/v6 v6.3.0 // indirect
)

replace github.com/apcera/gssapi => github.com/openshift/gssapi v0.0.0-20161010215902-5fb4217df13b
// branch: extend-include-path-apple-silicon
replace github.com/apcera/gssapi => github.com/tchap/gssapi v0.0.0-20260403121208-047531cb33ea
Comment on lines +223 to +224
Copy link
Copy Markdown

@coderabbitai coderabbitai bot Apr 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Personal fork introduces supply chain risk.

Using github.com/tchap/gssapi (a personal fork) instead of an official OpenShift-maintained fork creates a supply chain dependency on an individual's repository. While this may be acceptable as a temporary measure (as noted in PR comments pending merge of openshift/gssapi#4), ensure there's a plan to migrate to an official fork once the upstream changes are merged.

Would you like me to open an issue to track the migration from the personal fork to the official fork after openshift/gssapi#4 is merged?

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@go.mod` around lines 223 - 224, The go.mod replace directive currently
pointing at the personal fork github.com/tchap/gssapi (replace
github.com/apcera/gssapi => github.com/tchap/gssapi ...) introduces supply-chain
risk; update the replace to point to the official openshift fork
(github.com/openshift/gssapi) once openshift/gssapi#4 is merged, or add a short
TODO and create/link an issue to track migration, and ensure the replace line is
removed or updated to the released tag/commit of github.com/openshift/gssapi in
go.mod (reference the replace directive and the module name
github.com/apcera/gssapi to find the change).

⚠️ Potential issue | 🔴 Critical

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Description: Verify the tchap/gssapi fork exists, contains Apple Silicon fixes, and check for API changes

# Check if the fork exists and has recent commits
echo "=== Checking fork existence and recent commits ==="
gh repo view tchap/gssapi --json name,description,pushedAt,defaultBranchRef

# Check for commits related to Apple Silicon or macOS
echo -e "\n=== Checking for Apple Silicon / macOS related commits ==="
gh api repos/tchap/gssapi/commits?per_page=20 | jq -r '.[] | "\(.commit.committer.date) - \(.commit.message)"' | head -20

# Compare exported Go symbols between old and new fork
echo -e "\n=== Comparing API exports between forks ==="
echo "Note: This requires both repositories to be cloned for deep comparison"
echo "Old fork: github.com/openshift/gssapi (commit from 2016)"
echo "New fork: github.com/tchap/gssapi (commit 047531cb33ea)"

# Check if the specific commit exists in the fork
echo -e "\n=== Verifying commit 047531cb33ea exists ==="
gh api repos/tchap/gssapi/commits/047531cb33ea --jq '{sha: .sha, message: .commit.message, date: .commit.committer.date}'

Repository: openshift/oc

Length of output: 799

🌐 Web query:

tchap/gssapi github fork apple silicon

💡 Result:

No GitHub repository named tchap/gssapi or a fork by tchap (tchapgouv organization) of any GSSAPI library was found. Tchapgouv (French government Tchap Matrix client org) has many repos like tchap-desktop, tchap-ios (Apple Silicon compatible as iOS app), tchap-web-v4, but none matching "gssapi". General GSSAPI projects support Apple Silicon: golang-auth/go-gssapi-c works on MacOS Apple Kerberos by default (no special fork needed), MacPorts gss builds on arm64, Apple provides GSS.framework. Older Tchap-related LinkedIn mentions (e.g., developers at TCHAP agency) exist but no repo link. If seeking GSSAPI for Tchap on Apple Silicon, use standard Go or C bindings as they natively support macOS ARM64.

Citations:

🏁 Script executed:

# Check the actual gssapi usage in the codebase
find . -name "negotiator_gssapi.go" -type f | head -5

Repository: openshift/oc

Length of output: 106

🏁 Script executed:

# Look at the full context of the replacement in go.mod around lines 223-224
cat go.mod | sed -n '215,230p'

Repository: openshift/oc

Length of output: 650

🏁 Script executed:

# Search for all gssapi imports and usage patterns
rg "gssapi\." -A 2 -B 1 | head -100

Repository: openshift/oc

Length of output: 5853

🏁 Script executed:

# Search for any references to tchap/gssapi in the codebase to understand context
rg "tchap/gssapi" -n

Repository: openshift/oc

Length of output: 663

🏁 Script executed:

# Check git history to see when this was added and any PR context
git log -p --all -S "tchap/gssapi" | head -100

Repository: openshift/oc

Length of output: 38

🏁 Script executed:

# Look for any comments or documentation about this fork
rg "extend-include-path-apple-silicon" -B 5 -A 5

Repository: openshift/oc

Length of output: 519

🏁 Script executed:

# Search GitHub for any fork with similar name or by searching commits
rg "047531cb33ea" .

Repository: openshift/oc

Length of output: 653

🏁 Script executed:

# Check if there's any documentation about where this fork comes from
find . -name "*.md" -o -name "*.txt" | xargs grep -l "tchap" 2>/dev/null | head -5

Repository: openshift/oc

Length of output: 76

🏁 Script executed:

# Look at PR/issue context in git branches
git branch -a | grep -i apple
git branch -a | grep -i extend

Repository: openshift/oc

Length of output: 38

The referenced fork github.com/tchap/gssapi is not publicly accessible on GitHub and will cause builds to fail.

A web search confirms no public tchap/gssapi repository exists under the Tchapgouv organization or any "tchap" user on GitHub. While go.sum contains hash entries indicating the dependency was resolved previously, this fork cannot be publicly resolved now, which breaks reproducibility and prevents any build from successfully fetching dependencies without private access credentials.

Before merging:

  • Confirm the fork exists and is intentionally private (if so, document the requirement and authentication method).
  • If the fork was deleted or the path is incorrect, use the correct, publicly accessible fork location.
  • If this is experimental/WIP code, consider whether merging to a stable branch is appropriate without public fork availability.

This creates a critical supply chain and reproducibility concern regardless of API compatibility between the forks.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@go.mod` around lines 223 - 224, The go.mod replace directive referencing
"github.com/tchap/gssapi" is pointing to a non-public fork and will break public
builds; either confirm the fork is intentionally private and document required
access/authentication, or replace/remove the replace directive so it references
a publicly accessible module. Specifically, update the replace line in go.mod
(the "replace github.com/apcera/gssapi => github.com/tchap/gssapi
v0.0.0-...-047531cb33ea" entry) to the correct public fork/path or revert to the
upstream "github.com/apcera/gssapi", then run "go get" / "go mod tidy" to
refresh go.sum and verify builds succeed; if the private fork is required, add
documentation in the repo explaining how to authenticate and fetch that
dependency.


replace github.com/onsi/ginkgo/v2 => github.com/openshift/onsi-ginkgo/v2 v2.6.1-0.20251001123353-fd5b1fb35db1
4 changes: 2 additions & 2 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,8 +375,6 @@ github.com/openshift/build-machinery-go v0.0.0-20251023084048-5d77c1a5e5af h1:Ui
github.com/openshift/build-machinery-go v0.0.0-20251023084048-5d77c1a5e5af/go.mod h1:8jcm8UPtg2mCAsxfqKil1xrmRMI3a+XU2TZ9fF8A7TE=
github.com/openshift/client-go v0.0.0-20260306160707-3935d929fc7d h1:T+9HFgEEcnu1TDDfsO5JcJC6N0/Kzob5AtG9IpITHJ8=
github.com/openshift/client-go v0.0.0-20260306160707-3935d929fc7d/go.mod h1:tIA3XSb/WsC/Fg0YNRfs/JrMrloBKPGF+NKVutd7nMI=
github.com/openshift/gssapi v0.0.0-20161010215902-5fb4217df13b h1:it0YPE/evO6/m8t8wxis9KFI2F/aleOKsI6d9uz0cEk=
github.com/openshift/gssapi v0.0.0-20161010215902-5fb4217df13b/go.mod h1:tNrEB5k8SI+g5kOlsCmL2ELASfpqEofI0+FLBgBdN08=
github.com/openshift/library-go v0.0.0-20260303171201-5d9eb6295ff6 h1:xjqy0OolrFdJ+ofI/aD0+2k9+MSk5anP5dXifFt539Q=
github.com/openshift/library-go v0.0.0-20260303171201-5d9eb6295ff6/go.mod h1:D797O/ssKTNglbrGchjIguFq+DbyRYdeds5w4/VTrKM=
github.com/openshift/onsi-ginkgo/v2 v2.6.1-0.20251001123353-fd5b1fb35db1 h1:PMTgifBcBRLJJiM+LgSzPDTk9/Rx4qS09OUrfpY6GBQ=
Expand Down Expand Up @@ -460,6 +458,8 @@ github.com/stretchr/testify v1.8.0/go.mod h1:yNjHg4UonilssWZ8iaSj1OCr/vHnekPRkoO
github.com/stretchr/testify v1.8.1/go.mod h1:w2LPCIKwWwSfY2zedu0+kehJoqGctiVI29o6fzry7u4=
github.com/stretchr/testify v1.11.1 h1:7s2iGBzp5EwR7/aIZr8ao5+dra3wiQyKjjFuvgVKu7U=
github.com/stretchr/testify v1.11.1/go.mod h1:wZwfW3scLgRK+23gO65QZefKpKQRnfz6sD981Nm4B6U=
github.com/tchap/gssapi v0.0.0-20260403121208-047531cb33ea h1:qg5uvBpWX+no879/J/HjishOHgaiOkCp+vOJFbPzgU0=
github.com/tchap/gssapi v0.0.0-20260403121208-047531cb33ea/go.mod h1:xQz4s+i4JqtlGyYPzsvBxduNunUHCXucLrJNtkgmVbY=
github.com/titanous/rocacheck v0.0.0-20171023193734-afe73141d399 h1:e/5i7d4oYZ+C1wj2THlRK+oAhjeS/TRQwMfkIuet3w0=
github.com/titanous/rocacheck v0.0.0-20171023193734-afe73141d399/go.mod h1:LdwHTNJT99C5fTAzDz0ud328OgXz+gierycbcIx2fRs=
github.com/ulikunitz/xz v0.5.12 h1:37Nm15o69RwBkXM0J6A5OlE67RZTfzUxTj8fB3dfcsc=
Expand Down
3 changes: 2 additions & 1 deletion vendor/github.com/apcera/gssapi/name.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions vendor/modules.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ github.com/alicebob/sqlittle/sql
# github.com/antlr4-go/antlr/v4 v4.13.0
## explicit; go 1.20
github.com/antlr4-go/antlr/v4
# github.com/apcera/gssapi v0.0.0-00010101000000-000000000000 => github.com/openshift/gssapi v0.0.0-20161010215902-5fb4217df13b
# github.com/apcera/gssapi v0.0.0-00010101000000-000000000000 => github.com/tchap/gssapi v0.0.0-20260403121208-047531cb33ea
## explicit
github.com/apcera/gssapi
# github.com/aws/aws-sdk-go-v2 v1.41.3
Expand Down Expand Up @@ -2040,5 +2040,5 @@ sigs.k8s.io/structured-merge-diff/v6/value
sigs.k8s.io/yaml
sigs.k8s.io/yaml/goyaml.v3
sigs.k8s.io/yaml/kyaml
# github.com/apcera/gssapi => github.com/openshift/gssapi v0.0.0-20161010215902-5fb4217df13b
# github.com/apcera/gssapi => github.com/tchap/gssapi v0.0.0-20260403121208-047531cb33ea
# github.com/onsi/ginkgo/v2 => github.com/openshift/onsi-ginkgo/v2 v2.6.1-0.20251001123353-fd5b1fb35db1