Skip to content

Update non-admin CRDs to include ReadyToStart backup phase#2144

Merged
Joeavaikath merged 1 commit intoopenshift:oadp-devfrom
Joeavaikath:update-non-admin-manifests
Mar 31, 2026
Merged

Update non-admin CRDs to include ReadyToStart backup phase#2144
Joeavaikath merged 1 commit intoopenshift:oadp-devfrom
Joeavaikath:update-non-admin-manifests

Conversation

@Joeavaikath
Copy link
Copy Markdown
Contributor

Why the changes were made

The NonAdminBackup CRD was missing the ReadyToStart phase in its
validation enum. Velero added this phase but make update-non-admin-manifests
was never run to sync the latest CRDs from the oadp-non-admin repo,
causing validation errors when backups transitioned through this phase.

How to test the changes made

  • make test
  • Deploy OADP with non-admin enabled
  • Create a NonAdminBackup and verify no validation errors for ReadyToStart phase
  • make bundle-isupdated

🤖 Generated with Claude Code

Syncs NonAdminBackup CRD from latest oadp-non-admin repo to include the
ReadyToStart phase added in Velero, fixing validation errors when backups
transition through this phase.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 30, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 2b2bd6e7-2cb6-4507-beca-0923629cce87

📥 Commits

Reviewing files that changed from the base of the PR and between f2f8c5e and 2075a9c.

📒 Files selected for processing (2)
  • bundle/manifests/oadp.openshift.io_nonadminbackups.yaml
  • config/crd/bases/oadp.openshift.io_nonadminbackups.yaml

Walkthrough

The NonAdminBackup CRD schema is extended with support for volume group snapshot labeling and backup queue management. Two new fields (volumeGroupSnapshotLabelKey string and queuePosition integer) are introduced, and the backup phase enum gains two additional states (Queued and ReadyToStart).

Changes

Cohort / File(s) Summary
CRD Schema Extensions
bundle/manifests/oadp.openshift.io_nonadminbackups.yaml, config/crd/bases/oadp.openshift.io_nonadminbackups.yaml
Added volumeGroupSnapshotLabelKey string field to spec and status schema; introduced Queued and ReadyToStart phase enum values; added queuePosition integer field for queue tracking.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot requested review from mpryc and sseago March 30, 2026 16:14
@Joeavaikath
Copy link
Copy Markdown
Contributor Author

/cherry-pick oadp-1.6

@openshift-cherrypick-robot
Copy link
Copy Markdown
Contributor

@Joeavaikath: once the present PR merges, I will cherry-pick it on top of oadp-1.6 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick oadp-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 30, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Mar 30, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Joeavaikath, kaovilai, weshayutin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Joeavaikath
Copy link
Copy Markdown
Contributor Author

/retest

@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Mar 30, 2026

@Joeavaikath: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Joeavaikath Joeavaikath merged commit b999579 into openshift:oadp-dev Mar 31, 2026
14 of 15 checks passed
@openshift-cherrypick-robot
Copy link
Copy Markdown
Contributor

@Joeavaikath: new pull request could not be created: failed to create pull request against openshift/oadp-operator#oadp-1.6 from head openshift-cherrypick-robot:cherry-pick-2144-to-oadp-1.6: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for openshift-cherrypick-robot:cherry-pick-2144-to-oadp-1.6."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

Details

In response to this:

/cherry-pick oadp-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants