Update non-admin CRDs to include ReadyToStart backup phase#2144
Conversation
Syncs NonAdminBackup CRD from latest oadp-non-admin repo to include the ReadyToStart phase added in Velero, fixing validation errors when backups transition through this phase. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughThe NonAdminBackup CRD schema is extended with support for volume group snapshot labeling and backup queue management. Two new fields ( Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/cherry-pick oadp-1.6 |
|
@Joeavaikath: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Joeavaikath, kaovilai, weshayutin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
@Joeavaikath: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@Joeavaikath: new pull request could not be created: failed to create pull request against openshift/oadp-operator#oadp-1.6 from head openshift-cherrypick-robot:cherry-pick-2144-to-oadp-1.6: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for openshift-cherrypick-robot:cherry-pick-2144-to-oadp-1.6."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"} DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Why the changes were made
The NonAdminBackup CRD was missing the
ReadyToStartphase in itsvalidation enum. Velero added this phase but
make update-non-admin-manifestswas never run to sync the latest CRDs from the
oadp-non-adminrepo,causing validation errors when backups transitioned through this phase.
How to test the changes made
make testmake bundle-isupdated🤖 Generated with Claude Code