Skip to content

Package HPP systemd service in Microshift RPM for SELinux policies#695

Merged
openshift-merge-robot merged 1 commit intoopenshift:mainfrom
oglok:fix_643
May 30, 2022
Merged

Package HPP systemd service in Microshift RPM for SELinux policies#695
openshift-merge-robot merged 1 commit intoopenshift:mainfrom
oglok:fix_643

Conversation

@oglok
Copy link
Copy Markdown
Contributor

@oglok oglok commented May 25, 2022

Signed-off-by: Ricardo Noriega rnoriega@redhat.com

Closes #643

@openshift-ci openshift-ci bot requested review from copejon and fzdarsky May 25, 2022 15:49
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 25, 2022
@oglok
Copy link
Copy Markdown
Contributor Author

oglok commented May 25, 2022

I've tested this patch on a RHEL 4 Edge system with MicroShift embedded into the ostree.

[redhat@localhost ~]$ oc get pods -A
NAMESPACE                       NAME                                  READY   STATUS    RESTARTS   AGE
default                         test                                  1/1     Running   0          3h8m
kube-system                     kube-flannel-ds-2mhg6                 1/1     Running   0          3h15m
kubevirt-hostpath-provisioner   kubevirt-hostpath-provisioner-w8ch4   1/1     Running   0          3h15m
openshift-dns                   dns-default-wgxmk                     2/2     Running   0          3h15m
openshift-dns                   node-resolver-gcgc8                   1/1     Running   0          3h15m
openshift-ingress               router-default-6c96f6bc66-vtwb4       1/1     Running   0          3h15m
openshift-service-ca            service-ca-7bffb6f6bf-kvw5x           1/1     Running   0          3h15m
[redhat@localhost ~]$ 
[redhat@localhost ~]$ sudo systemctl status hostpath-provisioner.service 
● hostpath-provisioner.service - Set SELinux chcon for hostpath-provisioner
   Loaded: loaded (/etc/systemd/system/hostpath-provisioner.service; disabled; vendor preset: disabled)
   Active: inactive (dead)

May 25 08:43:01 localhost.localdomain systemd[1]: Started Set SELinux chcon for hostpath-provisioner.
May 25 08:43:01 localhost.localdomain systemd[1]: hostpath-provisioner.service: Succeeded.
[redhat@localhost ~]$ 

[redhat@localhost ~]$ oc get pvc
NAME       STATUS   VOLUME                                     CAPACITY   ACCESS MODES   STORAGECLASS                    AGE
pvc-test   Bound    pvc-020c26ff-7b23-48cd-825c-fbb31686ac3c   16Gi       RWO            kubevirt-hostpath-provisioner   3h9m
[redhat@localhost ~]$ ll /var/hpvolumes/
total 0
drwxrwxrwx. 2 root root 6 May 25 08:48 pvc-020c26ff-7b23-48cd-825c-fbb31686ac3c

@copejon
Copy link
Copy Markdown
Contributor

copejon commented May 25, 2022

@oglok Please rebase to main:HEAD to pickup the kuttl test changes. That'll fix the kuttl related CI failures.

@ggiguash
Copy link
Copy Markdown
Contributor

ggiguash commented May 26, 2022

USHIFT-38

Copy link
Copy Markdown
Contributor

@mangelajo mangelajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of tiny comments, thanks @oglok ! :)

Signed-off-by: Ricardo Noriega <rnoriega@redhat.com>
@oglok
Copy link
Copy Markdown
Contributor Author

oglok commented May 26, 2022

/retest

@copejon copejon requested a review from mangelajo May 26, 2022 19:25
Copy link
Copy Markdown
Contributor

@mangelajo mangelajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 30, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented May 30, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: copejon, mangelajo, oglok

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [copejon,mangelajo,oglok]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented May 30, 2022

@oglok: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 71b25ff into openshift:main May 30, 2022
@mangelajo mangelajo mentioned this pull request Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] hostpath provisioner “permission denied” on R4E due to SELinux

5 participants