Skip to content

OCPBUGS-70107: Observability tests are failing when restarting microshift-observability service#5967

Merged
openshift-merge-bot[bot] merged 2 commits intoopenshift:mainfrom
agullon:OCPBUGS-70107
Dec 22, 2025
Merged

OCPBUGS-70107: Observability tests are failing when restarting microshift-observability service#5967
openshift-merge-bot[bot] merged 2 commits intoopenshift:mainfrom
agullon:OCPBUGS-70107

Conversation

@agullon
Copy link
Contributor

@agullon agullon commented Dec 22, 2025

Latest opentelemetry-collector-0.135.0-2.el9_7 version includes a fix for CVE-2025-68156 causing OTEL to identify brackets on IPv4 addresses as invalid URLs. Example:

Dec 22 05:01:13 el96-src-optional-bootc-host1 opentelemetry-collector[8497]: 2025-12-22T05:01:13.690Z        error        service/service.go:153        error found during service initialization        {"resource": {"service.instance.id": "c69e256b-8211-42a3-8aa6-887f0295de8e", "service.name": "otelcol", "service.version": "0.135.0"}, "error": "failed to build pipelines: failed to create \"otlphttp/loki\" exporter for data type \"logs\": endpoint must be a valid URL"}

This PR addresses the issue by setting brackets only for IPv6 addresses.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Dec 22, 2025
@openshift-ci-robot
Copy link

@agullon: This pull request references Jira Issue OCPBUGS-70107, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from copejon and eslutsky December 22, 2025 11:26
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 22, 2025
@openshift-ci-robot
Copy link

@agullon: This pull request references Jira Issue OCPBUGS-70107, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
Details

In response to this:

Latest opentelemetry-collector-0.135.0-2.el9_7 version includes a fix for CVE-2025-68156 causing OTEL to identify brackets on IPv4 addresses as invalid URLs. Example:

Dec 22 05:01:13 el96-src-optional-bootc-host1 opentelemetry-collector[8497]: 2025-12-22T05:01:13.690Z        error        service/service.go:153        error found during service initialization        {"resource": {"service.instance.id": "c69e256b-8211-42a3-8aa6-887f0295de8e", "service.name": "otelcol", "service.version": "0.135.0"}, "error": "failed to build pipelines: failed to create \"otlphttp/loki\" exporter for data type \"logs\": endpoint must be a valid URL"}

This PR addresses the issue by setting brackets only for IPv6 addresses.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ggiguash
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Dec 22, 2025
@ggiguash
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 22, 2025
@ggiguash
Copy link
Contributor

/cherry-pick release-4.21 release-4.20 release-4.19

@openshift-cherrypick-robot

@ggiguash: once the present PR merges, I will cherry-pick it on top of release-4.21 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.21 release-4.20 release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 22, 2025
@ggiguash
Copy link
Contributor

/lgtm
/verified by ci

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Dec 22, 2025
@openshift-ci-robot
Copy link

@ggiguash: This PR has been marked as verified by ci.

Details

In response to this:

/lgtm
/verified by ci

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 22, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: agullon, ggiguash

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ggiguash
Copy link
Contributor

Looking at the failed tests, there seems to be no connection with the change. Overriding to save CI cycles
/override ci/prow/e2e-aws-tests-arm ci/prow/e2e-aws-tests-bootc

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 22, 2025

@ggiguash: Overrode contexts on behalf of ggiguash: ci/prow/e2e-aws-tests-arm, ci/prow/e2e-aws-tests-bootc

Details

In response to this:

Looking at the failed tests, there seems to be no connection with the change. Overriding to save CI cycles
/override ci/prow/e2e-aws-tests-arm ci/prow/e2e-aws-tests-bootc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 22, 2025

@agullon: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 6786b8f into openshift:main Dec 22, 2025
10 checks passed
@openshift-ci-robot
Copy link

@agullon: Jira Issue OCPBUGS-70107: All pull requests linked via external trackers have merged:

All linked pull requests have the verified tag. Jira Issue OCPBUGS-70107 has been moved to the VERIFIED state.

Details

In response to this:

Latest opentelemetry-collector-0.135.0-2.el9_7 version includes a fix for CVE-2025-68156 causing OTEL to identify brackets on IPv4 addresses as invalid URLs. Example:

Dec 22 05:01:13 el96-src-optional-bootc-host1 opentelemetry-collector[8497]: 2025-12-22T05:01:13.690Z        error        service/service.go:153        error found during service initialization        {"resource": {"service.instance.id": "c69e256b-8211-42a3-8aa6-887f0295de8e", "service.name": "otelcol", "service.version": "0.135.0"}, "error": "failed to build pipelines: failed to create \"otlphttp/loki\" exporter for data type \"logs\": endpoint must be a valid URL"}

This PR addresses the issue by setting brackets only for IPv6 addresses.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot

@ggiguash: new pull request created: #5968

Details

In response to this:

/cherry-pick release-4.21 release-4.20 release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@agullon
Copy link
Contributor Author

agullon commented Dec 22, 2025

/cherry-pick release-4.20
/cherry-pick release-4.19

@openshift-cherrypick-robot

@agullon: #5967 failed to apply on top of branch "release-4.19":

Applying: set brackets in otel_config.yaml only for ipv6
Using index info to reconstruct a base tree...
M	test/assets/observability/otel_config.yaml
M	test/suites/optional/observability.robot
Falling back to patching base and 3-way merge...
Auto-merging test/suites/optional/observability.robot
Auto-merging test/assets/observability/otel_config.yaml
CONFLICT (content): Merge conflict in test/assets/observability/otel_config.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 set brackets in otel_config.yaml only for ipv6

Details

In response to this:

/cherry-pick release-4.20
/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@agullon
Copy link
Contributor Author

agullon commented Dec 22, 2025

/cherry-pick release-4.20

@openshift-cherrypick-robot

@agullon: #5967 failed to apply on top of branch "release-4.20":

Applying: set brackets in otel_config.yaml only for ipv6
Using index info to reconstruct a base tree...
M	test/assets/observability/otel_config.yaml
M	test/suites/optional/observability.robot
Falling back to patching base and 3-way merge...
Auto-merging test/suites/optional/observability.robot
Auto-merging test/assets/observability/otel_config.yaml
CONFLICT (content): Merge conflict in test/assets/observability/otel_config.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 set brackets in otel_config.yaml only for ipv6

Details

In response to this:

/cherry-pick release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants