USHIFT-6380: Fix OLM test flakes#5933
Conversation
|
Skipping CI for Draft Pull Request. |
|
@pacevedom: This pull request references USHIFT-6380 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target either version "4.22." or "openshift-4.22.", but it targets "openshift-4.21" instead. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pacevedom The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
|
Just found a different issue, will push a different fix. |
1efb439 to
021ec3d
Compare
|
/test ? |
|
@pacevedom: The following commands are available to trigger required jobs: The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test e2e-aws-tests-bootc |
scripts/mirror-images.sh
Outdated
| echo "ERROR: Could not successfully verify mirrored image '${dst_img}'" >&2 | ||
| return 1 | ||
| fi | ||
| rm -rf "${tmp_dir}" |
There was a problem hiding this comment.
Did we measure how much longer it takes to run mirroring with this verification?
Especially with the images already present on the disk, the second pass performance might be hit significantly.
IMO, I'm not sure we need this type of verification because we never found an evidence that skopeo does not report download errors.
There was a problem hiding this comment.
This was a leftover from previous investigation, which is wrong. Now it should be ok, going to run all tests couple of times to see if the flake manifests itself.
021ec3d to
31a534c
Compare
|
/test e2e-aws-tests-bootc |
|
e2e-aws-tests-periodics: greenboot timeout while waiting for cert-manager to start |
|
/test e2e-aws-tests-bootc |
|
@pacevedom: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Closing in favor of #5942, which also adds more scenarios |
|
@ggiguash: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
No description provided.