Skip to content

USHIFT-6404: Persist microshift_variant macro in specfile#5892

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
pmtk:rpm-variant
Dec 15, 2025
Merged

USHIFT-6404: Persist microshift_variant macro in specfile#5892
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
pmtk:rpm-variant

Conversation

@pmtk
Copy link
Member

@pmtk pmtk commented Dec 11, 2025

If not persisted, there's no way to override it when rebuilding the RPMs from SRPM (see microshift-io/microshift#164)

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 11, 2025
@openshift-ci-robot
Copy link

@pmtk: This pull request explicitly references no jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 11, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 11, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2025
@pmtk pmtk marked this pull request as ready for review December 11, 2025 17:11
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 11, 2025
@pmtk
Copy link
Member Author

pmtk commented Dec 11, 2025

/retest

@pmtk
Copy link
Member Author

pmtk commented Dec 12, 2025

/verified by @pmtk

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Dec 12, 2025
@openshift-ci-robot
Copy link

@pmtk: This PR has been marked as verified by @pmtk.

Details

In response to this:

/verified by @pmtk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ggiguash
Copy link
Contributor

/cherry-pick release-4.21 release-4.20 release-4.19

@openshift-cherrypick-robot

@ggiguash: once the present PR merges, I will cherry-pick it on top of release-4.21 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.21 release-4.20 release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ggiguash
Copy link
Contributor

/test all

@ggiguash
Copy link
Contributor

ggiguash commented Dec 15, 2025

/retitle USHIFT-6404: Persist microshift_variant macro in specfile

@openshift-ci openshift-ci bot changed the title NO-ISSUE: Persist microshift_variant macro in specfile USHIFT-6404: Persist microshift_variant macro in specfile Dec 15, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 15, 2025

@pmtk: This pull request references USHIFT-6404 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

If not persisted, there's no way to override it when rebuilding the RPMs from SRPM (see microshift-io/microshift#164)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ggiguash
Copy link
Contributor

/lgtm
/verified by ci

@openshift-ci-robot
Copy link

@ggiguash: This PR has been marked as verified by ci.

Details

In response to this:

/lgtm
/verified by ci

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 15, 2025

@pmtk: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit da992d0 into openshift:main Dec 15, 2025
11 checks passed
@openshift-cherrypick-robot

@ggiguash: new pull request created: #5909

Details

In response to this:

/cherry-pick release-4.21 release-4.20 release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants