Skip to content

NO-ISSUE: Fix comparison of local and remote branch#5848

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
pmtk:rebase-fix-local-remote-branch-cmp
Dec 3, 2025
Merged

NO-ISSUE: Fix comparison of local and remote branch#5848
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
pmtk:rebase-fix-local-remote-branch-cmp

Conversation

@pmtk
Copy link
Member

@pmtk pmtk commented Dec 3, 2025

They both start from base_branch, not adjusted_base_branch. Adjusted base branch is used for PR target branch.

They both start from base_branch, not adjusted_base_branch.
Adjusted base branch is used for PR target branch.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 3, 2025
@openshift-ci-robot
Copy link

@pmtk: This pull request explicitly references no jira issue.

Details

In response to this:

They both start from base_branch, not adjusted_base_branch. Adjusted base branch is used for PR target branch.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from eslutsky and pacevedom December 3, 2025 09:45
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 3, 2025
Copy link
Contributor

@pacevedom pacevedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pacevedom, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pmtk
Copy link
Member Author

pmtk commented Dec 3, 2025

/verified by @pmtk
/override ci/prow/e2e-aws-tests-bootc ci/prow/e2e-aws-tests-bootc-arm

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Dec 3, 2025
@openshift-ci-robot
Copy link

@pmtk: This PR has been marked as verified by @pmtk.

Details

In response to this:

/verified by @pmtk
/override ci/prow/e2e-aws-tests-bootc ci/prow/e2e-aws-tests-bootc-arm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 3, 2025

@pmtk: Overrode contexts on behalf of pmtk: ci/prow/e2e-aws-tests-bootc, ci/prow/e2e-aws-tests-bootc-arm

Details

In response to this:

/verified by @pmtk
/override ci/prow/e2e-aws-tests-bootc ci/prow/e2e-aws-tests-bootc-arm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 3, 2025

@pmtk: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit ae559a2 into openshift:main Dec 3, 2025
10 checks passed
@pmtk pmtk deleted the rebase-fix-local-remote-branch-cmp branch December 3, 2025 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants