Skip to content

[release-4.19] NO-ISSUE: Sync vendor/ to be consistent with content of deps/#5816

Closed
adobes1 wants to merge 1 commit intoopenshift:release-4.19from
adobes1:4.19-sync-vendor
Closed

[release-4.19] NO-ISSUE: Sync vendor/ to be consistent with content of deps/#5816
adobes1 wants to merge 1 commit intoopenshift:release-4.19from
adobes1:4.19-sync-vendor

Conversation

@adobes1
Copy link

@adobes1 adobes1 commented Nov 27, 2025

prefetch-dependencies task is failing when building microshift-bootc hermetically because of modified vendor/ directory (ART internal build URL)

  2025-11-27 10:46:40,010 ERROR [mode:STRICT] vendor directory changed after vendoring:
  M	vendor/k8s.io/apimachinery/third_party/forked/golang/json/fields.go
  M	vendor/k8s.io/client-go/third_party/forked/golang/template/exec.go
  M	vendor/k8s.io/client-go/third_party/forked/golang/template/funcs.go
  2025-11-27 10:46:40,177 DEBUG Running `/usr/local/go/go1.21/bin/go clean -modcache`
  2025-11-27 10:46:44,955 ERROR PackageRejected: The content of the vendor directory is not consistent with go.mod. Please check the logs for more details.
  Error: PackageRejected: The content of the vendor directory is not consistent with go.mod. Please check the logs for more details.
    Please try running `go mod vendor` and committing the changes.
    Note that you may need to `git add --force` ignored files in the vendor/ dir.
    Docs: https://github.com/hermetoproject/hermeto/blob/main/docs/gomod.md#vendoring

This PR ensures that there's no diff after running go mod vendor

This change ensures that there's no diff when running
go mod vendor. Without this change, microshift-bootc image
can't be built hermetically.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 27, 2025
@openshift-ci-robot
Copy link

@adobes1: This pull request explicitly references no jira issue.

Details

In response to this:

prefetch-dependencies task is failing when building microshift-bootc hermetically because of modified vendor/ directory (ART internal build URL)

 2025-11-27 10:46:40,010 ERROR [mode:STRICT] vendor directory changed after vendoring:
 M	vendor/k8s.io/apimachinery/third_party/forked/golang/json/fields.go
 M	vendor/k8s.io/client-go/third_party/forked/golang/template/exec.go
 M	vendor/k8s.io/client-go/third_party/forked/golang/template/funcs.go
 2025-11-27 10:46:40,177 DEBUG Running `/usr/local/go/go1.21/bin/go clean -modcache`
 2025-11-27 10:46:44,955 ERROR PackageRejected: The content of the vendor directory is not consistent with go.mod. Please check the logs for more details.
 Error: PackageRejected: The content of the vendor directory is not consistent with go.mod. Please check the logs for more details.
   Please try running `go mod vendor` and committing the changes.
   Note that you may need to `git add --force` ignored files in the vendor/ dir.
   Docs: https://github.com/hermetoproject/hermeto/blob/main/docs/gomod.md#vendoring

This PR ensures that there's no diff after running go mod vendor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from agullon and jogeo November 27, 2025 10:59
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 27, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: adobes1
Once this PR has been reviewed and has the lgtm label, please assign pmtk for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 27, 2025

@adobes1: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ggiguash
Copy link
Contributor

/retitle [release-4.19] NO-ISSUE: Sync vendor/ to be consistent with content of deps/

@openshift-ci openshift-ci bot changed the title NO-ISSUE: Sync vendor/ to be consistent with content of deps/ [release-4.19] NO-ISSUE: Sync vendor/ to be consistent with content of deps/ Nov 27, 2025
@adobes1
Copy link
Author

adobes1 commented Nov 28, 2025

Closing in favor of #5822
/close

@openshift-ci openshift-ci bot closed this Nov 28, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 28, 2025

@adobes1: Closed this PR.

Details

In response to this:

Closing in favor of #5822
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants