USHIFT-6348: Retry brew access check#5808
USHIFT-6348: Retry brew access check#5808openshift-merge-bot[bot] merged 2 commits intoopenshift:mainfrom
Conversation
|
@agullon: This pull request explicitly references no jira issue. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
|
@agullon: This pull request references USHIFT-6348 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.21.0" version, but no target version was set. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
test/bin/manage_brew_rpms.sh
Outdated
| break | ||
| fi | ||
| sleep "${i}" | ||
| done |
There was a problem hiding this comment.
Should we use --retry and --retry-delay to simplify the code?
It lacks the incremental delay, but that should not be a big deal overall, should it?
There was a problem hiding this comment.
thank you for this suggestion, I didn't know bout these flags
|
/retest |
|
/retitle USHIFT-6348: Retry brew access check |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: agullon, ggiguash The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
The job failed on AWS stack destruction. Overriding to save on the CI cycles. /verified by CI |
|
@ggiguash: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@ggiguash: Overrode contexts on behalf of ggiguash: ci/prow/e2e-aws-tests-periodic DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
|
/retry |
|
@agullon: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
No description provided.