Skip to content

USHIFT-6348: Retry brew access check#5808

Merged
openshift-merge-bot[bot] merged 2 commits intoopenshift:mainfrom
agullon:patch-32
Nov 27, 2025
Merged

USHIFT-6348: Retry brew access check#5808
openshift-merge-bot[bot] merged 2 commits intoopenshift:mainfrom
agullon:patch-32

Conversation

@agullon
Copy link
Contributor

@agullon agullon commented Nov 26, 2025

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 26, 2025
@openshift-ci-robot
Copy link

@agullon: This pull request explicitly references no jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 26, 2025
@agullon
Copy link
Contributor Author

agullon commented Nov 26, 2025

/retest

@agullon agullon changed the title NO-ISSUE: Add retry logic for curl command to check brew access USHIFT-6348 Cache job must fail when RPM packages are NOT downloaded from brew Nov 26, 2025
@agullon agullon changed the title USHIFT-6348 Cache job must fail when RPM packages are NOT downloaded from brew USHIFT-6348: Cache job must fail when RPM packages are NOT downloaded from brew Nov 26, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 26, 2025

@agullon: This pull request references USHIFT-6348 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

break
fi
sleep "${i}"
done
Copy link
Contributor

@ggiguash ggiguash Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use --retry and --retry-delay to simplify the code?
It lacks the incremental delay, but that should not be a big deal overall, should it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for this suggestion, I didn't know bout these flags

@agullon
Copy link
Contributor Author

agullon commented Nov 26, 2025

/retest

@ggiguash
Copy link
Contributor

ggiguash commented Nov 27, 2025

/retitle USHIFT-6348: Retry brew access check
/lgtm

@openshift-ci openshift-ci bot changed the title USHIFT-6348: Cache job must fail when RPM packages are NOT downloaded from brew USHIFT-6348: Retry brew access check Nov 27, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 27, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: agullon, ggiguash

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ggiguash
Copy link
Contributor

The job failed on AWS stack destruction. Overriding to save on the CI cycles.

/verified by CI
/override ci/prow/e2e-aws-tests-periodic

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Nov 27, 2025
@openshift-ci-robot
Copy link

@ggiguash: This PR has been marked as verified by CI.

Details

In response to this:

The job failed on AWS stack destruction. Overriding to save on the CI cycles.

/verified by CI
/override ci/prow/e2e-aws-tests-periodic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 27, 2025

@ggiguash: Overrode contexts on behalf of ggiguash: ci/prow/e2e-aws-tests-periodic

Details

In response to this:

The job failed on AWS stack destruction. Overriding to save on the CI cycles.

/verified by CI
/override ci/prow/e2e-aws-tests-periodic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e5673f1 and 2 for PR HEAD 44a60d7 in total

@agullon
Copy link
Contributor Author

agullon commented Nov 27, 2025

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e66336e and 1 for PR HEAD 44a60d7 in total

@agullon
Copy link
Contributor Author

agullon commented Nov 27, 2025

/retry

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD c7123f7 and 0 for PR HEAD 44a60d7 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 27, 2025

@agullon: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit baf6b30 into openshift:main Nov 27, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants