USHIFT-6342: Merging scenarios#5798
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@kasturinarra: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
/test e2e-aws-tests-bootc-arm |
openshift-ci
bot
added
the
approved
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
|
||
| scenario_run_tests() { | ||
| # Run lifecycle tests first (restart tests), then misc tests (config tests) | ||
| # This order ensures no interference between tests |
There was a problem hiding this comment.
why they must run in order? afaik, by default, RF execute them in random order every time
There was a problem hiding this comment.
if you need to, you can add export TEST_RANDOMIZATION=none at the init of the scenario
There was a problem hiding this comment.
I thought they should , but looking at the code i see TEST_RANDOMIZATION="all" is the default setting in test/bin/scenario.sh which means Robot Framework will randomize test execution order. So looking at each suite i see they have proper setup and teardown, so i thin we are good here. I will remove these comments from the code.
| scenario_run_tests() { | ||
| run_tests host1 suites/fault-tests | ||
| # Run fault-tests first (network outage tests), then greenboot (boot health tests) | ||
| # This order ensures no interference between tests |
There was a problem hiding this comment.
do these 2 also must run in order? if so, I think it's better to run fault-tests in the last position, because they may disrupt some things in the cluster
There was a problem hiding this comment.
same comment as above.
There was a problem hiding this comment.
do not forget to add export TEST_RANDOMIZATION=none if you want to ensure execution order
kasturinarra
changed the title
|
@kasturinarra: This pull request references USHIFT-6342 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
kasturinarra
force-pushed
the
local-4.21
branch
from
d0bba6b to
c15691e
Compare
test/scenarios-bootc/periodics/el96-src@osconfig-lifecycle-and-misc.sh
Outdated
Show resolved
Hide resolved
kasturinarra
force-pushed
the
local-4.21
branch
2 times, most recently
from
fa38ed8 to
78b3d71
Compare
|
/retest |
|
/test e2e-aws-tests-bootc-arm |
|
/test e2e-aws-tests-bootc-periodic |
|
/test e2e-aws-tests-bootc-periodic-arm |
|
/retest |
|
From the latests executions on periodics jobs I can see
So I suggest merging gitops + telemetry + Clusterid + Systemd-Resolved. They all take about 16 mins. |
will check in sometime and get back... |
@kasturinarra If you move these 4 test suites into 1 scenario, you should use |
kasturinarra
force-pushed
the
local-4.21
branch
from
78b3d71 to
b38eef7
Compare
kasturinarra
force-pushed
the
local-4.21
branch
from
b38eef7 to
aa822bf
Compare
|
/retest |
There was a problem hiding this comment.
You don't need to use rhel96-bootc-source-gitops image in this scenario, because you are not running gitops tests. You can just use rhel96-bootc-source.
| # Sourced from scenario.sh and uses functions defined there. | ||
|
|
||
| # Disable test randomization to ensure systemd-resolved runs last | ||
| # (it reboots the host which would break SSH for subsequent tests) |
There was a problem hiding this comment.
In previous executions, the issue you mention here is not reproducible: https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/logs/periodic-ci-openshift-microshift-release-4.21-periodics-e2e-aws-tests-bootc-nightly/1992790592513380352/artifacts/e2e-aws-tests-bootc-nightly/openshift-microshift-e2e-metal-tests/artifacts/scenario-info/el96-src@osconfig-misc/log.html
There was a problem hiding this comment.
Just added there for safety to make sure things do not go wrong as adding it there also does not cause any harm so..
kasturinarra
force-pushed
the
local-4.21
branch
from
aa822bf to
24c3212
Compare
|
/retest |
|
/test e2e-aws-tests-bootc-periodic |
|
@kasturinarra: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: agullon, kasturinarra The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/verified by CI |
openshift-ci-robot
added
the
verified
|
@kasturinarra: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
3 participants
Merging scenarios to make sure hypervisor resources are not choked up during the execution.