USHIFT-6106: Adding optional scenarios to releases directory#5797
Conversation
openshift-ci
bot
added
the
approved
kasturinarra
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@kasturinarra: This pull request references USHIFT-6106 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
With these 3 new scenarios you are adding will have 30 scenarios in releases repository. This is around the limit of hypervisor resources, so I'd suggest removing the 2 scenarios you added for standard suites in #5695 PR in favor of the new 2 standard scenarios with the upgrade. |
| scenario_create_vms() { | ||
| exit_if_image_not_found "${dest_image}" | ||
|
|
||
| prepare_kickstart host1 kickstart-bootc.ks.template rhel96-bootc-brew-y2-with-optional |
There was a problem hiding this comment.
can you move outside rhel96-bootc-brew-y2-with-optional as a start_image variables
| scenario_create_vms() { | ||
| exit_if_image_not_found "${dest_image}" | ||
|
|
||
| prepare_kickstart host1 kickstart-bootc.ks.template rhel96-bootc-brew-y2-with-optional |
There was a problem hiding this comment.
why updgrade from y2 and not from y1?
@agullon ah looking back i think i misunderstood... let me remove the upgrade as they are really not necessary for now. |
kasturinarra
force-pushed
the
add_three_more_scenarios_rhel10
branch
from
8935b34 to
564fe4c
Compare
| run_tests host1 \ | ||
| --variable "PROMETHEUS_HOST:$(hostname)" \ | ||
| --variable "PROMETHEUS_PORT:9092" \ | ||
| --variable "LOKI_HOST:$(hostname)" \ | ||
| --variable "LOKI_PORT:3200" \ | ||
| --variable "PROM_EXPORTER_PORT:8889" \ | ||
| suites/optional/ |
There was a problem hiding this comment.
| run_tests host1 \ | |
| --variable "PROMETHEUS_HOST:$(hostname)" \ | |
| --variable "PROMETHEUS_PORT:9092" \ | |
| --variable "LOKI_HOST:$(hostname)" \ | |
| --variable "LOKI_PORT:3200" \ | |
| --variable "PROM_EXPORTER_PORT:8889" \ | |
| suites/optional/ | |
| run_tests host1 \ | |
| --variable "PROMETHEUS_HOST:$(hostname)" \ | |
| --variable "PROMETHEUS_PORT:9093" \ | |
| --variable "LOKI_HOST:$(hostname)" \ | |
| --variable "LOKI_PORT:3201" \ | |
| --variable "PROM_EXPORTER_PORT:8889" \ | |
| suites/optional/ |
changing the ports to not reuse the same port (it'll cause an error trying to open same port) from https://github.com/openshift/microshift/blob/main/test/scenarios-bootc/releases/el96-lrel%40optional.sh scenario
kasturinarra
force-pushed
the
add_three_more_scenarios_rhel10
branch
from
564fe4c to
cf261c4
Compare
|
/lgtm |
|
/retest |
1 similar comment
|
/retest |
|
/test e2e-aws-tests-bootc-release-arm |
|
@kasturinarra do you mind to change the PR title to avoid confusion? it says |
kasturinarra
changed the title
|
@kasturinarra: This pull request references USHIFT-6106 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm cancel |
kasturinarra
force-pushed
the
add_three_more_scenarios_rhel10
branch
from
ff0175d to
191e851
Compare
|
/test e2e-aws-tests e2e-aws-tests-arm |
kasturinarra
force-pushed
the
add_three_more_scenarios_rhel10
branch
from
191e851 to
748db15
Compare
|
/retest |
|
/test e2e-aws-tests-bootc-release-arm |
kasturinarra
force-pushed
the
add_three_more_scenarios_rhel10
branch
5 times, most recently
from
c6ddc13 to
2f13332
Compare
|
/test e2e-aws-tests-release |
|
/test e2e-aws-tests-bootc-release /test e2e-aws-tests-bootc-release-arm |
kasturinarra
force-pushed
the
add_three_more_scenarios_rhel10
branch
4 times, most recently
from
1155d2e to
b43877d
Compare
|
/test e2e-aws-tests-periodic |
|
/test e2e-aws-tests-bootc-release-arm e2e-aws-tests-bootc-release e2e-aws-tests-release e2e-aws-tests-release-arm |
|
/test e2e-aws-tests-periodic-arm e2e-aws-tests-periodic |
|
/test e2e-aws-tests-periodic |
kasturinarra
force-pushed
the
add_three_more_scenarios_rhel10
branch
from
b43877d to
15ed2bf
Compare
|
Overriding quite a few tests to make progress. All of the reported issues are handled elsewhere. |
|
@ggiguash: Overrode contexts on behalf of ggiguash: ci/prow/e2e-aws-tests, ci/prow/e2e-aws-tests-arm, ci/prow/e2e-aws-tests-bootc-release, ci/prow/e2e-aws-tests-bootc-release-arm, ci/prow/e2e-aws-tests-periodic, ci/prow/e2e-aws-tests-periodic-arm, ci/prow/e2e-aws-tests-release, ci/prow/e2e-aws-tests-release-arm DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@kasturinarra: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
openshift-ci-robot
added
the
verified
|
@ggiguash: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ggiguash, kasturinarra The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-4.21 |
|
@kasturinarra: new pull request created: #5934 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
5 participants
Adding optional scenario to releases directory