USHIFT-6141: SR-IOV RF smoke test by vanhalenar · Pull Request #5796 · openshift/microshift

vanhalenar · 2025-11-24T10:18:53Z

This test is deploying a NetworkNodePolicy and checking if the VFs are configured correctly.

openshift-ci-robot · 2025-11-24T10:18:57Z

@vanhalenar: This pull request references USHIFT-6141 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2025-11-24T10:18:58Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

openshift-ci · 2025-11-24T10:19:08Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vanhalenar
Once this PR has been reviewed and has the lgtm label, please assign jerpeter1 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

vanhalenar · 2025-11-24T10:19:26Z

/test ?

openshift-ci · 2025-11-24T10:19:34Z

@vanhalenar: The following commands are available to trigger required jobs:

/test e2e-aws-ai-model-serving

/test e2e-aws-footprint-and-performance

/test e2e-aws-tests

/test e2e-aws-tests-arm

/test e2e-aws-tests-bootc

/test e2e-aws-tests-bootc-arm

/test e2e-aws-tests-bootc-periodic

/test e2e-aws-tests-bootc-periodic-arm

/test e2e-aws-tests-bootc-release

/test e2e-aws-tests-bootc-release-arm

/test e2e-aws-tests-bootc-upstream

/test e2e-aws-tests-bootc-upstream-arm

/test e2e-aws-tests-cache

/test e2e-aws-tests-cache-arm

/test e2e-aws-tests-periodic

/test e2e-aws-tests-periodic-arm

/test e2e-aws-tests-release

/test e2e-aws-tests-release-arm

/test ocp-full-conformance-rhel-eus

/test ocp-full-conformance-serial-rhel-eus

/test test-rpm

/test test-unit

/test verify

The following commands are available to trigger optional jobs:

/test images

/test security

/test test-rebase

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-microshift-main-e2e-aws-tests

pull-ci-openshift-microshift-main-e2e-aws-tests-arm

pull-ci-openshift-microshift-main-e2e-aws-tests-bootc

pull-ci-openshift-microshift-main-e2e-aws-tests-bootc-arm

pull-ci-openshift-microshift-main-e2e-aws-tests-bootc-periodic

pull-ci-openshift-microshift-main-e2e-aws-tests-bootc-periodic-arm

pull-ci-openshift-microshift-main-e2e-aws-tests-periodic

pull-ci-openshift-microshift-main-e2e-aws-tests-periodic-arm

pull-ci-openshift-microshift-main-images

pull-ci-openshift-microshift-main-security

pull-ci-openshift-microshift-main-test-unit

pull-ci-openshift-microshift-main-verify

Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

vanhalenar · 2025-11-24T11:05:50Z

/test e2e-aws-tests-bootc

vanhalenar · 2025-11-24T12:11:38Z

/test e2e-aws-tests-bootc

openshift-ci-robot · 2025-11-24T13:06:42Z

@vanhalenar: This pull request references USHIFT-6141 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

Details

In response to this:

This is a very basic smoke test. I will be adding one more test to this - deploying a NetworkNodePolicy and checking if the VFs are configured correctly.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

test/bin/common.sh

pkg/healthcheck/microshift_optional_workloads.go

test/bin/common.sh

test/suites/optional/sriov.robot

vanhalenar · 2025-11-25T15:47:33Z

/test e2e-aws-tests-bootc

test/bin/scenario.sh

test/suites/optional/sriov.robot

vanhalenar · 2025-11-28T09:41:33Z

/test e2e-aws-tests-bootc

vanhalenar · 2025-12-01T11:48:06Z

/test e2e-aws-tests-bootc

openshift-ci-robot · 2025-12-01T12:08:50Z

@vanhalenar: This pull request references USHIFT-6141 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

Details

In response to this:

This test is deploying a NetworkNodePolicy and checking if the VFs are configured correctly.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

vanhalenar · 2025-12-01T14:18:29Z

/test e2e-aws-tests-bootc

openshift-ci · 2025-12-01T15:20:39Z

@vanhalenar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-tests-bootc	`4bd176e`	link	true	`/test e2e-aws-tests-bootc`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

agullon · 2025-12-01T16:35:45Z

test/suites/optional/sriov.robot

+Create VFs And Verify
+    [Documentation]    Deploys sriovnetworknodepolicy and verifies the VF configuration
+
+    VAR    ${testcmd}=    oc get sriovnetworknodestate -o yaml -n sriov-network-operator -o json


Suggested change

VAR ${testcmd}= oc get sriovnetworknodestate -o yaml -n sriov-network-operator -o json

VAR ${testcmd}= oc get sriovnetworknodestate -n sriov-network-operator -o json

because you already have -o json this change won't affect the behaviour

agullon · 2025-12-01T16:36:09Z

test/suites/optional/sriov.robot

+    VAR    ${testcmd}=    oc get sriovnetworknodestate -o yaml -n sriov-network-operator -o json
+    Run With Kubeconfig    ${testcmd}
+    VAR    ${cmd}=
+    ...    oc get sriovnetworknodestate -o yaml -n sriov-network-operator -o json | jq -r '.items[].status.interfaces[0].pciAddress'


Suggested change

... oc get sriovnetworknodestate -o yaml -n sriov-network-operator -o json | jq -r '.items[].status.interfaces[0].pciAddress'

... oc get sriovnetworknodestate -n sriov-network-operator -o json | jq -r '.items[].status.interfaces[0].pciAddress'

ggiguash · 2025-12-02T10:21:46Z

test/scenarios-bootc/presubmits/el96-src@optional.sh

    prepare_kickstart host1 kickstart-bootc.ks.template rhel96-bootc-source-optionals
    # Two nics - one for macvlan, another for ipvlan (they cannot enslave the same interface)
-    launch_vm --boot_blueprint rhel96-bootc --network "${VM_MULTUS_NETWORK},${VM_MULTUS_NETWORK}"
+    launch_vm --boot_blueprint rhel96-bootc --network "sriov,${VM_MULTUS_NETWORK},${VM_MULTUS_NETWORK}"


Let's use a variable for sriov network name?

pacevedom · 2025-12-04T16:49:22Z

/close
Superseded by #5858

openshift-merge-robot · 2025-12-04T16:49:31Z

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci · 2025-12-04T16:50:19Z

@pacevedom: Closed this PR.

Details

In response to this:

/close
Superseded by #5858

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

vanhalenar added 3 commits November 24, 2025 09:57

Add sriov test

7af4540

Fix shellcheck

bcb5263

Minor fixes

9d61d63

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 24, 2025

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 24, 2025

Temporarily disable all tests except for optional

e021706

Add entry for healthcheck, fix RF test naming

e8650dd

agullon reviewed Nov 24, 2025

View reviewed changes

test/bin/common.sh Show resolved Hide resolved

pacevedom reviewed Nov 25, 2025

View reviewed changes

Add test case, address comments

da636d7

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 25, 2025

vanhalenar and others added 2 commits November 25, 2025 16:39

Move RPMS to Y1

f84a816

Merge branch 'main' into sriov-image

bd9b43f

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 25, 2025

agullon reviewed Nov 25, 2025

View reviewed changes

test/bin/scenario.sh Outdated Show resolved Hide resolved

agullon reviewed Nov 25, 2025

View reviewed changes

test/suites/optional/sriov.robot Outdated Show resolved Hide resolved

agullon reviewed Nov 25, 2025

View reviewed changes

test/suites/optional/sriov.robot Outdated Show resolved Hide resolved

agullon reviewed Nov 25, 2025

View reviewed changes

test/suites/optional/sriov.robot Outdated Show resolved Hide resolved

Address comments

9c37a2e

Move SR-IOV back to current release RPMs list

09e8137

Add debug line

4bd176e

agullon reviewed Dec 1, 2025

View reviewed changes

ggiguash reviewed Dec 2, 2025

View reviewed changes

Minor workload fix

69b9d01

pacevedom mentioned this pull request Dec 4, 2025

USHIFT-6141: SR-IOV e2e tests #5858

Merged

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 4, 2025

openshift-ci bot closed this Dec 4, 2025

	VAR ${testcmd}= oc get sriovnetworknodestate -o yaml -n sriov-network-operator -o json
	VAR ${testcmd}= oc get sriovnetworknodestate -n sriov-network-operator -o json

	... oc get sriovnetworknodestate -o yaml -n sriov-network-operator -o json \| jq -r '.items[].status.interfaces[0].pciAddress'
	... oc get sriovnetworknodestate -n sriov-network-operator -o json \| jq -r '.items[].status.interfaces[0].pciAddress'

Conversation

vanhalenar commented Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Nov 24, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Nov 24, 2025

Uh oh!

openshift-ci bot commented Nov 24, 2025

Uh oh!

vanhalenar commented Nov 24, 2025

Uh oh!

openshift-ci bot commented Nov 24, 2025

Uh oh!

vanhalenar commented Nov 24, 2025

Uh oh!

vanhalenar commented Nov 24, 2025

Uh oh!

openshift-ci-robot commented Nov 24, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vanhalenar commented Nov 25, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vanhalenar commented Nov 28, 2025

Uh oh!

vanhalenar commented Dec 1, 2025

Uh oh!

openshift-ci-robot commented Dec 1, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vanhalenar commented Dec 1, 2025

Uh oh!

openshift-ci bot commented Dec 1, 2025

Uh oh!

agullon Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

agullon Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

ggiguash Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

pacevedom commented Dec 4, 2025

Uh oh!

openshift-merge-robot commented Dec 4, 2025

Uh oh!

openshift-ci bot commented Dec 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

vanhalenar commented Nov 24, 2025 •

edited

Loading

openshift-ci-robot commented Nov 24, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Nov 24, 2025 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Dec 1, 2025 •

edited by openshift-ci bot

Loading