USHIFT-6338: Use single instances of Prometheus and Loki for all tests#5779
USHIFT-6338: Use single instances of Prometheus and Loki for all tests#5779openshift-merge-bot[bot] merged 12 commits intoopenshift:mainfrom
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
/test all |
openshift-ci
bot
added
the
approved
agullon
left a comment
agullon
left a comment
There was a problem hiding this comment.
The resourcedetection processor is a great idea, but I do have 2 concerns going forward with this approach:
- It'll be more complicated to run scenarios in local env, because the Prometheus/Loki server must be started before running the test instead of within the scenario.
- Prometheus and Loki servers are always started, but in some cases we don't need them because there are no scenarios using Prometheus or Loki, for example: test/scenarios/presubmits
| MicroShift Reports Metrics To Prometheus Server | ||
| [Documentation] Check the expected metrics are sent to the local server. | ||
| [Setup] Run Keywords | ||
| ... Start Prometheus Server ${PROMETHEUS_PORT} | ||
| ... AND | ||
| ... Setup Telemetry Configuration ${ENABLE_TELEMETRY_TO_PROMETHUS} ${PULL_SECRET_METRICS} | ||
| [Setup] Setup Telemetry Configuration ${ENABLE_TELEMETRY_TO_PROMETHUS} ${PULL_SECRET_METRICS} | ||
|
|
||
| Should Find Metrics In Journal Log Success Metrics sent successfully | ||
|
|
||
| @{metrics_to_check}= Get List Prometheus Metrics To Check | ||
| FOR ${metric} IN @{metrics_to_check} | ||
| Check Prometheus Query ${PROMETHEUS_HOST} ${PROMETHEUS_PORT} ${metric} | ||
| Check Prometheus Query ${PROMETHEUS_HOST} ${PROMETHEUS_PORT} ${metric} add_hostname_filter=${False} | ||
| END | ||
|
|
||
| [Teardown] Run Keywords | ||
| ... Remove Telemetry Configuration | ||
| ... AND | ||
| ... Stop Prometheus Server ${PROMETHEUS_PORT} | ||
| [Teardown] Remove Telemetry Configuration |
There was a problem hiding this comment.
This MicroShift Reports Metrics To Prometheus Server Test Case must be executed always in the last place in this Test Suite. If not, the other 2 Prometheus Test Cases will fail because they'll find metrics in the Prometheus server.
This is the reason why, in the original implementation, the Prometheus server starts and stops for every Test Case.
There was a problem hiding this comment.
That would explain weird failure I've seen locally
pmtk
force-pushed
the
single-prom-loki
branch
from
2997900 to
175eff7
Compare
|
/test all |
openshift-merge-robot
added
the
needs-rebase
pmtk
force-pushed
the
single-prom-loki
branch
from
175eff7 to
f95d892
Compare
|
/test all |
openshift-merge-robot
removed
the
needs-rebase
pmtk
force-pushed
the
single-prom-loki
branch
from
f95d892 to
868dc31
Compare
pmtk
force-pushed
the
single-prom-loki
branch
from
868dc31 to
f098c4b
Compare
|
/test all |
1 similar comment
|
/test all |
pmtk
force-pushed
the
single-prom-loki
branch
from
6a61de6 to
2786b58
Compare
|
/test all |
pmtk
force-pushed
the
single-prom-loki
branch
from
2786b58 to
96ba780
Compare
|
/retst |
|
/retest |
|
/test all |
|
/retitle USHIFT-6338:Use single instances of Prometheus and Loki for all tests |
openshift-ci
bot
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
openshift-ci-robot
added
the
jira/valid-reference
|
@pmtk: This pull request references USHIFT-6338 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
pmtk
changed the title
|
/retest |
|
/override ci/prow/e2e-aws-tests-bootc-periodic ci/prow/e2e-aws-tests-bootc-periodic-arm ci/prow/e2e-aws-tests-bootc-release ci/prow/e2e-aws-tests-bootc-release-arm ci/prow/e2e-aws-tests-periodic ci/prow/e2e-aws-tests-periodic-arm ci/prow/e2e-aws-tests-release ci/prow/e2e-aws-tests-release-arm |
|
/verified by @pmtk |
openshift-ci-robot
added
the
verified
|
@pmtk: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pacevedom, pmtk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@pmtk: Overrode contexts on behalf of pmtk: ci/prow/e2e-aws-tests-bootc-periodic, ci/prow/e2e-aws-tests-bootc-periodic-arm, ci/prow/e2e-aws-tests-bootc-release, ci/prow/e2e-aws-tests-bootc-release-arm, ci/prow/e2e-aws-tests-periodic, ci/prow/e2e-aws-tests-periodic-arm, ci/prow/e2e-aws-tests-release, ci/prow/e2e-aws-tests-release-arm DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/e2e-aws-tests-bootc-periodic ci/prow/e2e-aws-tests-bootc-periodic-arm ci/prow/e2e-aws-tests-bootc-release ci/prow/e2e-aws-tests-bootc-release-arm ci/prow/e2e-aws-tests-periodic ci/prow/e2e-aws-tests-periodic-arm ci/prow/e2e-aws-tests-release ci/prow/e2e-aws-tests-release-arm ci/prow/e2e-aws-tests ci/prow/e2e-aws-tests failure is unrelated |
|
@pmtk: Overrode contexts on behalf of pmtk: ci/prow/e2e-aws-tests, ci/prow/e2e-aws-tests-bootc-periodic, ci/prow/e2e-aws-tests-bootc-periodic-arm, ci/prow/e2e-aws-tests-bootc-release, ci/prow/e2e-aws-tests-bootc-release-arm, ci/prow/e2e-aws-tests-periodic, ci/prow/e2e-aws-tests-periodic-arm, ci/prow/e2e-aws-tests-release, ci/prow/e2e-aws-tests-release-arm DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test all |
|
/override ci/prow/e2e-aws-tests-bootc-periodic ci/prow/e2e-aws-tests-bootc-periodic-arm ci/prow/e2e-aws-tests-bootc-release ci/prow/e2e-aws-tests-bootc-release-arm ci/prow/e2e-aws-tests-periodic ci/prow/e2e-aws-tests-periodic-arm ci/prow/e2e-aws-tests-release ci/prow/e2e-aws-tests-release-arm |
|
@pmtk: Overrode contexts on behalf of pmtk: ci/prow/e2e-aws-tests-bootc-periodic, ci/prow/e2e-aws-tests-bootc-periodic-arm, ci/prow/e2e-aws-tests-bootc-release, ci/prow/e2e-aws-tests-bootc-release-arm, ci/prow/e2e-aws-tests-periodic, ci/prow/e2e-aws-tests-periodic-arm, ci/prow/e2e-aws-tests-release, ci/prow/e2e-aws-tests-release-arm DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@pmtk: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
6 participants
No description provided.