USHIFT-6133: Add more robot framework test cases#5776
USHIFT-6133: Add more robot framework test cases#5776openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
kasturinarra
changed the title
openshift-ci
bot
added
the
approved
|
@kasturinarra: This pull request references USHIFT-6133 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
kasturinarra
force-pushed
the
host-file-update
branch
from
b5ec996 to
79d6f40
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
kasturinarra
force-pushed
the
host-file-update
branch
2 times, most recently
from
0dd9a18 to
f31a87c
Compare
|
/retest |
test/suites/standard1/dns.robot
Outdated
| Router Should Resolve Hostname | ||
| [Documentation] Check if the router pod resolves the given hostname | ||
| [Arguments] ${hostname} | ||
| [Arguments] ${hostname} ${expected_ip}=${EMPTY} |
There was a problem hiding this comment.
why do we need ${expected_ip}=${EMPTY}, where is that being called?
There was a problem hiding this comment.
I have used it for a different test case which i removed, but forgot to remove this. Now removed it. Could you please help review again ? thanks !!
kasturinarra
force-pushed
the
host-file-update
branch
from
f31a87c to
f59cd61
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: eslutsky, kasturinarra The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@kasturinarra: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/verified by CI |
openshift-ci-robot
added
the
verified
|
@kasturinarra: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
3 participants
Which issue(s) this PR addresses: Adding three more robot framework test cases that check if hosts-file is dynamically updated with out restarting microshift, disabling microshift is deleting the hosts-file configmap in openshift-dns namespace, validating cluster DNS takes precedence over host file.
Closes #USHIFT-6133