Skip to content

USHIFT-6282: 'brew download-build' command fails#5679

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
agullon:brew_rpms_download_fix
Nov 4, 2025
Merged

USHIFT-6282: 'brew download-build' command fails#5679
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
agullon:brew_rpms_download_fix

Conversation

@agullon
Copy link
Contributor

@agullon agullon commented Oct 30, 2025

Add a fallback mechanism to download the RPMs using curl command with -k option to ignore invalid and self-signed certificate errors.

@agullon
Copy link
Contributor Author

agullon commented Oct 30, 2025

/test e2e-aws-tests-cache

@openshift-ci openshift-ci bot requested review from eslutsky and jerpeter1 October 30, 2025 11:56
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2025
@agullon agullon marked this pull request as draft October 30, 2025 11:57
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 30, 2025
@agullon
Copy link
Contributor Author

agullon commented Oct 30, 2025

/test e2e-aws-tests-cache

1 similar comment
@agullon
Copy link
Contributor Author

agullon commented Oct 30, 2025

/test e2e-aws-tests-cache

@agullon
Copy link
Contributor Author

agullon commented Oct 30, 2025

/test e2e-aws-tests-cache-arm

@agullon agullon changed the title add curl to download brew RPMs as a fallback mechanism when brew comm… USHIFT-6282: 'brew download-build' command fails Oct 30, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 30, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 30, 2025

@agullon: This pull request references USHIFT-6282 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@agullon agullon force-pushed the brew_rpms_download_fix branch from 4480532 to d52101d Compare October 30, 2025 14:15
@agullon agullon marked this pull request as ready for review October 30, 2025 14:15
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 30, 2025
@openshift-ci openshift-ci bot requested review from pacevedom and pmtk October 30, 2025 14:16
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 31, 2025

@agullon: This pull request references USHIFT-6282 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Add a fallback mechanism to download the RPMs using curl command with -k option to ignore invalid and self-signed certificate errors.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

local pkg_release="${version_and_release#*-}"

for current_arch in ${arch} noarch; do
local base_url="https://download-01.beak-001.prod.iad2.dc.redhat.com/rhel-9/brew/packages/microshift/${pkg_version}/${pkg_release}/${current_arch}/"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering if this URL is fixed or there are any other instances that might serve the same files?

local pkg_release="${version_and_release#*-}"

for current_arch in ${arch} noarch; do
local base_url="https://download-01.beak-001.prod.iad2.dc.redhat.com/rhel-9/brew/packages/microshift/${pkg_version}/${pkg_release}/${current_arch}/"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we make the rhel-9 configurable so that it would be easy later when new rhel versions are introduced ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I missed that, I'll do it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no references in the repo pointing to different RHEL 9 and RHEL 10. Neither there are MicroShift RPMs published for RHEL 10.
I think this should be addressed in a separate PR at the same time as other RHEL 9 references.

@kasturinarra
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: agullon, kasturinarra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [agullon,kasturinarra]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ggiguash
Copy link
Contributor

ggiguash commented Nov 4, 2025

/verified by ci

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Nov 4, 2025
@openshift-ci-robot
Copy link

@ggiguash: This PR has been marked as verified by ci.

Details

In response to this:

/verified by ci

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD cce8a4f and 2 for PR HEAD d52101d in total

@agullon
Copy link
Contributor Author

agullon commented Nov 4, 2025

/retest

@agullon
Copy link
Contributor Author

agullon commented Nov 4, 2025

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 92227bb and 1 for PR HEAD d52101d in total

@agullon
Copy link
Contributor Author

agullon commented Nov 4, 2025

/retest

2 similar comments
@agullon
Copy link
Contributor Author

agullon commented Nov 4, 2025

/retest

@agullon
Copy link
Contributor Author

agullon commented Nov 4, 2025

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 4, 2025

@agullon: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 6c853b5 into openshift:main Nov 4, 2025
13 checks passed
@agullon
Copy link
Contributor Author

agullon commented Nov 5, 2025

/cherrypick release-4.20

@openshift-cherrypick-robot

@agullon: new pull request created: #5694

Details

In response to this:

/cherrypick release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants