Skip to content

NO-ISSUE: fix lvms and tlsv13 RF tests#5637

Merged
openshift-merge-bot[bot] merged 17 commits intoopenshift:mainfrom
agullon:fix_tlsv13_ostree_ref
Nov 6, 2025
Merged

NO-ISSUE: fix lvms and tlsv13 RF tests#5637
openshift-merge-bot[bot] merged 17 commits intoopenshift:mainfrom
agullon:fix_tlsv13_ostree_ref

Conversation

@agullon
Copy link
Contributor

@agullon agullon commented Oct 20, 2025

  • fix SCENARIOS_SOURCES var from test/bin/ci_phase_boot_and_test.sh script
    • previously SCENARIO_TYPE var was always empty, with this change ginkgo binary is build before the scenarios start
  • split the code into 2 functions to be able to use them from lvms scenarios:
    • setup_oc_and_kubeconfig() and wait_for_microshift_to_be_ready()
  • fix start images for lvms and tlsv13 tests
  • add setup_oc_and_kubeconfig() in all lvms scenarios because kubeconfig file must be set before running lvms-helpersscripts

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 20, 2025
@openshift-ci-robot
Copy link

@agullon: This pull request explicitly references no jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 20, 2025
@openshift-ci openshift-ci bot requested review from eslutsky and vanhalenar October 20, 2025 07:50
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 20, 2025
@agullon
Copy link
Contributor Author

agullon commented Oct 20, 2025

/retest

4 similar comments
@agullon
Copy link
Contributor Author

agullon commented Oct 20, 2025

/retest

@agullon
Copy link
Contributor Author

agullon commented Oct 20, 2025

/retest

@agullon
Copy link
Contributor Author

agullon commented Oct 20, 2025

/retest

@agullon
Copy link
Contributor Author

agullon commented Oct 20, 2025

/retest

@agullon agullon changed the title NO-ISSUE: fix ostree ref on tlsv13 scenarios NO-ISSUE: fix ostree ref on tlsv13 and lvms scenarios Oct 20, 2025
@agullon
Copy link
Contributor Author

agullon commented Oct 20, 2025

/test e2e-aws-tests-bootc-arm

@agullon
Copy link
Contributor Author

agullon commented Oct 20, 2025

/test e2e-aws-tests-release-arm

@agullon
Copy link
Contributor Author

agullon commented Oct 20, 2025

/retest

5 similar comments
@agullon
Copy link
Contributor Author

agullon commented Oct 20, 2025

/retest

@agullon
Copy link
Contributor Author

agullon commented Oct 20, 2025

/retest

@agullon
Copy link
Contributor Author

agullon commented Oct 20, 2025

/retest

@agullon
Copy link
Contributor Author

agullon commented Oct 21, 2025

/retest

@agullon
Copy link
Contributor Author

agullon commented Oct 21, 2025

/retest

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2025
@agullon
Copy link
Contributor Author

agullon commented Nov 5, 2025

/retest

2 similar comments
@agullon
Copy link
Contributor Author

agullon commented Nov 5, 2025

/retest

@agullon
Copy link
Contributor Author

agullon commented Nov 5, 2025

/retest

@agullon
Copy link
Contributor Author

agullon commented Nov 5, 2025

/verified by CI

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Nov 5, 2025
@openshift-ci-robot
Copy link

@agullon: This PR has been marked as verified by CI.

Details

In response to this:

/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@agullon
Copy link
Contributor Author

agullon commented Nov 5, 2025

/retest all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 5, 2025

@agullon: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

/test e2e-aws-ai-model-serving
/test e2e-aws-footprint-and-performance
/test e2e-aws-tests
/test e2e-aws-tests-arm
/test e2e-aws-tests-bootc
/test e2e-aws-tests-bootc-arm
/test e2e-aws-tests-bootc-periodic
/test e2e-aws-tests-bootc-periodic-arm
/test e2e-aws-tests-bootc-release
/test e2e-aws-tests-bootc-release-arm
/test e2e-aws-tests-bootc-upstream
/test e2e-aws-tests-bootc-upstream-arm
/test e2e-aws-tests-cache
/test e2e-aws-tests-cache-arm
/test e2e-aws-tests-periodic
/test e2e-aws-tests-periodic-arm
/test e2e-aws-tests-release
/test e2e-aws-tests-release-arm
/test ocp-full-conformance-rhel-eus
/test ocp-full-conformance-serial-rhel-eus
/test test-rpm
/test test-unit
/test verify

The following commands are available to trigger optional jobs:

/test images
/test security
/test test-rebase

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-microshift-main-e2e-aws-tests
pull-ci-openshift-microshift-main-e2e-aws-tests-arm
pull-ci-openshift-microshift-main-e2e-aws-tests-bootc
pull-ci-openshift-microshift-main-e2e-aws-tests-bootc-arm
pull-ci-openshift-microshift-main-e2e-aws-tests-bootc-periodic
pull-ci-openshift-microshift-main-e2e-aws-tests-bootc-periodic-arm
pull-ci-openshift-microshift-main-e2e-aws-tests-bootc-release
pull-ci-openshift-microshift-main-e2e-aws-tests-bootc-release-arm
pull-ci-openshift-microshift-main-e2e-aws-tests-periodic
pull-ci-openshift-microshift-main-e2e-aws-tests-periodic-arm
pull-ci-openshift-microshift-main-e2e-aws-tests-release
pull-ci-openshift-microshift-main-e2e-aws-tests-release-arm
pull-ci-openshift-microshift-main-images
pull-ci-openshift-microshift-main-security
pull-ci-openshift-microshift-main-test-unit
pull-ci-openshift-microshift-main-verify
Details

In response to this:

/retest all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@agullon
Copy link
Contributor Author

agullon commented Nov 5, 2025

/test all

@openshift-ci-robot openshift-ci-robot removed the verified Signifies that the PR passed pre-merge verification criteria label Nov 5, 2025
@agullon
Copy link
Contributor Author

agullon commented Nov 5, 2025

/retest

1 similar comment
@agullon
Copy link
Contributor Author

agullon commented Nov 6, 2025

/retest

@pacevedom
Copy link
Contributor

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 6, 2025
@agullon
Copy link
Contributor Author

agullon commented Nov 6, 2025

/retest

1 similar comment
@agullon
Copy link
Contributor Author

agullon commented Nov 6, 2025

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 6, 2025

@agullon: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@agullon
Copy link
Contributor Author

agullon commented Nov 6, 2025

/verified by CI

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Nov 6, 2025
@openshift-ci-robot
Copy link

@agullon: This PR has been marked as verified by CI.

Details

In response to this:

/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

@pacevedom pacevedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 6, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: agullon, pacevedom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 798bca3 into openshift:main Nov 6, 2025
17 checks passed
@openshift-cherrypick-robot

@agullon: #5637 failed to apply on top of branch "release-4.20":

Applying: fix ostree ref on tlsv13 scenarios
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
CONFLICT (add/add): Merge conflict in test/scenarios/releases/el96-lrel@tlsv13-standard2.sh
Auto-merging test/scenarios/releases/el96-lrel@tlsv13-standard2.sh
CONFLICT (add/add): Merge conflict in test/scenarios/releases/el96-lrel@tlsv13-standard1.sh
Auto-merging test/scenarios/releases/el96-lrel@tlsv13-standard1.sh
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 fix ostree ref on tlsv13 scenarios

Details

In response to this:

/cherrypick release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

agullon added a commit to agullon/microshift that referenced this pull request Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants