Skip to content

[release-4.20] USHIFT-6030: Reenable sigstore tests for 4.20 rc #5636

Merged
openshift-merge-bot[bot] merged 5 commits intoopenshift:release-4.20from
ggiguash:sigstore-enable-420
Nov 6, 2025
Merged

[release-4.20] USHIFT-6030: Reenable sigstore tests for 4.20 rc #5636
openshift-merge-bot[bot] merged 5 commits intoopenshift:release-4.20from
ggiguash:sigstore-enable-420

Conversation

@ggiguash
Copy link
Contributor

This is a manual cherry-pick of #5551, adding insecureAcceptAnything exceptions for some images.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 20, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 20, 2025

@ggiguash: This pull request references USHIFT-6030 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target either version "4.20." or "openshift-4.20.", but it targets "openshift-4.21" instead.

Details

In response to this:

This is a manual cherry-pick of #5551, adding insecureAcceptAnything exceptions for some images.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from eslutsky and vanhalenar October 20, 2025 06:12
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 20, 2025
@ggiguash
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 20, 2025

@ggiguash: This pull request references USHIFT-6030 which is a valid jira issue.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ggiguash
Copy link
Contributor Author

/retest-required

@ggiguash
Copy link
Contributor Author

/test e2e-aws-tests

@ggiguash
Copy link
Contributor Author

/test images

@ggiguash
Copy link
Contributor Author

/retest

@ggiguash
Copy link
Contributor Author

/test all

1 similar comment
@ggiguash
Copy link
Contributor Author

ggiguash commented Nov 5, 2025

/test all

@pacevedom
Copy link
Contributor

/retest

@ggiguash
Copy link
Contributor Author

ggiguash commented Nov 6, 2025

/label backport-risk-assessed
/label jira/vaid-bug
/verified by ci

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Nov 6, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 6, 2025

@ggiguash: The label(s) /label jira/vaid-bug cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, ux-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, run-integration-tests, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, ok-to-test, stability-fix-approved, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

Details

In response to this:

/label backport-risk-assessed
/label jira/vaid-bug
/verified by ci

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Nov 6, 2025
@openshift-ci-robot
Copy link

@ggiguash: This PR has been marked as verified by ci.

Details

In response to this:

/label backport-risk-assessed
/label jira/vaid-bug
/verified by ci

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ggiguash
Copy link
Contributor Author

ggiguash commented Nov 6, 2025

/label jira/valid-bug

@openshift-ci openshift-ci bot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Nov 6, 2025
Copy link
Contributor

@pacevedom pacevedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 6, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pacevedom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD c239b7e and 2 for PR HEAD 82f3482 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 6, 2025

@ggiguash: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit edb9c72 into openshift:release-4.20 Nov 6, 2025
13 checks passed
@ggiguash ggiguash deleted the sigstore-enable-420 branch November 18, 2025 09:07
@ggiguash ggiguash restored the sigstore-enable-420 branch November 18, 2025 09:07
@ggiguash ggiguash deleted the sigstore-enable-420 branch November 18, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants