Populate the the NO_PROXY environment#561
Merged
oglok merged 2 commits intoopenshift:mainfrom Jan 21, 2022
Merged
Conversation
Contributor
|
/test e2e-rpm-install |
Fixes-Issue: openshift#558 Signed-off-by: Miguel Angel Ajo <majopela@redhat.com>
Contributor
|
/lgtm |
openshift-ci
bot
added
lgtm
mangelajo
changed the title
Signed-off-by: Miguel Angel Ajo <majopela@redhat.com>
mangelajo
commented
Jan 20, 2022
| } | ||
|
|
||
| // sort keys to avoid issues with map key ordering in go future versions on the unit-test side | ||
| sort.Strings(keys) |
Contributor
Author
There was a problem hiding this comment.
I know the sort is unnecessary on production, but guarantees key ordering during unit testing, which is not a problem in current go, but future go versions will change this.
Contributor
Author
|
Sorry for the new after LGTM, but it came without batteries included (testing :-P) |
Contributor
|
/lgtm |
Contributor
Author
|
ok, I verified it works on a reproduced environment. |
Contributor
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fzdarsky, oglok The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Feb 29, 2024
Merged
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes-Issue: #558
Signed-off-by: Miguel Angel Ajo majopela@redhat.com