Skip to content

USHIFT-6183: Fix ginkgo junit results#5537

Merged
openshift-merge-bot[bot] merged 2 commits intoopenshift:mainfrom
kasturinarra:fix_results_xml
Sep 29, 2025
Merged

USHIFT-6183: Fix ginkgo junit results#5537
openshift-merge-bot[bot] merged 2 commits intoopenshift:mainfrom
kasturinarra:fix_results_xml

Conversation

@kasturinarra
Copy link
Contributor

Which issue(s) this PR addresses: Ginkgo tests are generating an xml which show result as failed even though all tests have passed, raising a PR here to fix the same.

Closes #USHIFT-6183

@openshift-ci openshift-ci bot requested review from ggiguash and jogeo September 29, 2025 07:22
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 29, 2025
@kasturinarra kasturinarra marked this pull request as draft September 29, 2025 07:55
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 29, 2025
@kasturinarra
Copy link
Contributor Author

/test e2e-aws-tests-release

@kasturinarra
Copy link
Contributor Author

/test e2e-aws-tests-bootc-release

@kasturinarra
Copy link
Contributor Author

/test e2e-aws-tests-bootc-release

@kasturinarra kasturinarra marked this pull request as ready for review September 29, 2025 13:18
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 29, 2025
@openshift-ci openshift-ci bot requested review from agullon and copejon September 29, 2025 13:19
Co-authored-by: Alejandro Gullón <agullon@redhat.com>
@pacevedom
Copy link
Contributor

pacevedom commented Sep 29, 2025

/retitle USHIFT-6183: Fix ginkgo junit results

@openshift-ci openshift-ci bot changed the title Fix xml result USHIFT-6183: Fix ginkgo junit results Sep 29, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 29, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 29, 2025

@kasturinarra: This pull request references USHIFT-6183 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Which issue(s) this PR addresses: Ginkgo tests are generating an xml which show result as failed even though all tests have passed, raising a PR here to fix the same.

Closes #USHIFT-6183

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

agullon added a commit to agullon/microshift that referenced this pull request Sep 29, 2025
@agullon
Copy link
Contributor

agullon commented Sep 29, 2025

/retest-required

@agullon
Copy link
Contributor

agullon commented Sep 29, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: agullon, kasturinarra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [agullon,kasturinarra]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kasturinarra
Copy link
Contributor Author

/verified by ci

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 29, 2025
@openshift-ci-robot
Copy link

@kasturinarra: This PR has been marked as verified by ci.

Details

In response to this:

/verified by ci

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 7297640 and 2 for PR HEAD 2f5b5c2 in total

@agullon
Copy link
Contributor

agullon commented Sep 29, 2025

/override ci/prow/e2e-aws-tests-release ci/prow/e2e-aws-tests-bootc-release
Only lrel ginkgo tests are failing in those 2 CI jobs, issue will be addressed in #5518 PR

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 29, 2025

@agullon: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • ci/prow/e2e-aws-tests-bootc-release
  • ci/prow/e2e-aws-tests-release

Only the following failed contexts/checkruns were expected:

  • ci/prow/e2e-aws-tests
  • ci/prow/e2e-aws-tests-arm
  • ci/prow/e2e-aws-tests-bootc
  • ci/prow/e2e-aws-tests-bootc-arm
  • ci/prow/e2e-aws-tests-bootc-periodic
  • ci/prow/e2e-aws-tests-bootc-periodic-arm
  • ci/prow/e2e-aws-tests-periodic
  • ci/prow/e2e-aws-tests-periodic-arm
  • ci/prow/images
  • ci/prow/security
  • ci/prow/test-unit
  • ci/prow/verify
  • pull-ci-openshift-microshift-main-e2e-aws-tests
  • pull-ci-openshift-microshift-main-e2e-aws-tests-arm
  • pull-ci-openshift-microshift-main-e2e-aws-tests-bootc
  • pull-ci-openshift-microshift-main-e2e-aws-tests-bootc-arm
  • pull-ci-openshift-microshift-main-e2e-aws-tests-bootc-periodic
  • pull-ci-openshift-microshift-main-e2e-aws-tests-bootc-periodic-arm
  • pull-ci-openshift-microshift-main-e2e-aws-tests-periodic
  • pull-ci-openshift-microshift-main-e2e-aws-tests-periodic-arm
  • pull-ci-openshift-microshift-main-images
  • pull-ci-openshift-microshift-main-security
  • pull-ci-openshift-microshift-main-test-unit
  • pull-ci-openshift-microshift-main-verify
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

/override ci/prow/e2e-aws-tests-release ci/prow/e2e-aws-tests-bootc-release
Only lrel ginkgo tests are failing in those 2 CI jobs, issue will be addressed in #5518 PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 29, 2025

@kasturinarra: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-tests-release 93041a1 link true /test e2e-aws-tests-release
ci/prow/e2e-aws-tests-bootc-release 699d252 link true /test e2e-aws-tests-bootc-release

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 3e4d0b8 into openshift:main Sep 29, 2025
13 checks passed
agullon pushed a commit to agullon/microshift that referenced this pull request Oct 2, 2025
USHIFT-6183: Fix ginkgo junit results
(cherry picked from commit 3e4d0b8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants