USHIFT-5572: Add HTTP01 ACME test for cert-manager by kasturinarra · Pull Request #5320 · openshift/microshift

kasturinarra · 2025-08-13T10:23:02Z

Add new test case for cert-manager with local ACME server (Pebble) using HTTP01 challenge
Include Pebble server deployment configuration
Add keywords for DNS name retrieval, certificate verification, and cleanup

🤖 Generated with Claude Code

Which issue(s) this PR addresses: Creating a local acme server to t

Closes #

kasturinarra · 2025-08-13T10:24:55Z

@eslutsky could you please help review ? thanks !!
I have tried to add /etc/hosts entry but that kind of does not work here, and since QE vms have dns resolvable name i used that for now. May be we could discucss once you are back.

eslutsky · 2025-08-18T16:06:36Z

test/suites/optional/cert-manager.robot

+    ${subject_alt_names_line}=    Get Lines Containing String    ${config_content}    subjectAltNames:
+    ${first_line}=    Get Line    ${subject_alt_names_line}    0
+    ${alt_names_content}=    Get Regexp Matches    ${first_line}    \\[(.+?)\\]    1
+    VAR    ${alt_names_list}=    ${alt_names_content}[0]
+    # Get the first DNS name (before the first comma)
+    ${first_dns_name}=    Split String    ${alt_names_list}    ,    1
+    ${dns_name}=    Strip String    ${first_dns_name}[0]
+    Should Not Be Empty    ${dns_name}    msg=Failed to retrieve DNS name from MicroShift config
+    RETURN    ${dns_name}


Suggested change

${subject_alt_names_line}= Get Lines Containing String ${config_content} subjectAltNames:

${first_line}= Get Line ${subject_alt_names_line} 0

${alt_names_content}= Get Regexp Matches ${first_line} \\[(.+?)\\] 1

VAR ${alt_names_list}= ${alt_names_content}[0]

# Get the first DNS name (before the first comma)

${first_dns_name}= Split String ${alt_names_list} , 1

${dns_name}= Strip String ${first_dns_name}[0]

Should Not Be Empty ${dns_name} msg=Failed to retrieve DNS name from MicroShift config

RETURN ${dns_name}

${config_yaml}= Evaluate yaml.safe_load('''${config_content}''') modules=yaml

${first_dns_name}= Get From List ${config_yaml['apiServer']['subjectAltNames']} 0

Should Not Be Empty ${first_dns_name} msg=Failed to retrieve DNS name from MicroShift config

RETURN ${first_dns_name}

you can evalulate the config as yaml file and get the first item from subjectAltNames .

kasturinarra · 2025-09-03T13:37:53Z

/test security

kasturinarra · 2025-09-03T13:58:42Z

/test e2e-aws-tests-arm

kasturinarra · 2025-09-03T18:10:31Z

/test e2e-aws-tests-bootc

kasturinarra · 2025-09-03T18:10:46Z

/test e2e-aws-tests-bootc-arm

kasturinarra · 2025-09-17T13:56:26Z

/test e2e-aws-tests-bootc

kasturinarra · 2025-09-17T17:12:02Z

/test e2e-aws-tests-bootc

kasturinarra · 2025-09-23T07:55:31Z

/test e2e-aws-tests-bootc

kasturinarra · 2025-09-24T10:43:11Z

/test e2e-aws-tests-bootc-arm

kasturinarra · 2025-09-24T10:43:22Z

/test e2e-aws-tests-bootc

test/suites/optional/cert-manager.robot

kasturinarra · 2025-09-26T18:19:59Z

@eslutsky addressed all your comments, can you please help review again ? thanks !!

kasturinarra · 2025-09-26T19:40:17Z

/test e2e-aws-tests-bootc-arm

eslutsky · 2025-09-29T07:47:11Z

/lgtm

openshift-ci · 2025-09-29T07:48:04Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eslutsky, kasturinarra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [eslutsky,kasturinarra]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

eslutsky · 2025-09-29T08:10:03Z

/verified by ci

openshift-ci-robot · 2025-09-29T08:10:16Z

@eslutsky: This PR has been marked as verified by ci.

Details

In response to this:

/verified by ci

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-09-29T08:14:43Z

@kasturinarra: This pull request references USHIFT-5572 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Add new test case for cert-manager with local ACME server (Pebble) using HTTP01 challenge

Include Pebble server deployment configuration

Add keywords for DNS name retrieval, certificate verification, and cleanup

🤖 Generated with Claude Code

Which issue(s) this PR addresses: Creating a local acme server to t

Closes #

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-09-29T09:12:33Z

/retest-required

Remaining retests: 0 against base HEAD ec5a8e2 and 2 for PR HEAD 05a632f in total

openshift-ci · 2025-09-29T10:22:25Z

@kasturinarra: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

kasturinarra · 2025-09-29T10:40:06Z

/cherry-pick release-4.20

openshift-cherrypick-robot · 2025-09-29T10:40:51Z

@kasturinarra: new pull request created: #5540

Details

In response to this:

/cherry-pick release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-ci bot requested review from copejon and jerpeter1 August 13, 2025 10:23

kasturinarra force-pushed the cert-manager-http01-test branch 7 times, most recently from e9b49cb to 52f744f Compare August 18, 2025 07:43

eslutsky reviewed Aug 18, 2025

View reviewed changes

kasturinarra force-pushed the cert-manager-http01-test branch 5 times, most recently from e017908 to f686a50 Compare August 20, 2025 11:23

kasturinarra force-pushed the cert-manager-http01-test branch from f686a50 to bfeef46 Compare September 3, 2025 11:27

kasturinarra force-pushed the cert-manager-http01-test branch 2 times, most recently from 345336c to 1172447 Compare September 5, 2025 11:35

kasturinarra marked this pull request as draft September 5, 2025 11:52

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 5, 2025

kasturinarra force-pushed the cert-manager-http01-test branch from 1172447 to 4f7de9b Compare September 5, 2025 15:58

kasturinarra marked this pull request as ready for review September 5, 2025 16:06

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 5, 2025

openshift-ci bot requested a review from pmtk September 5, 2025 16:07

kasturinarra force-pushed the cert-manager-http01-test branch from 4f7de9b to 88ab792 Compare September 5, 2025 17:29

kasturinarra force-pushed the cert-manager-http01-test branch from 90f2e06 to 5bff3a4 Compare September 17, 2025 11:07

eslutsky reviewed Sep 25, 2025

View reviewed changes

test/suites/optional/cert-manager.robot Outdated Show resolved Hide resolved

eslutsky reviewed Sep 26, 2025

View reviewed changes

test/suites/optional/cert-manager.robot Outdated Show resolved Hide resolved

Add HTTP01 ACME test for cert-manager

05a632f

kasturinarra force-pushed the cert-manager-http01-test branch from 5bff3a4 to 05a632f Compare September 26, 2025 18:19

openshift-ci bot assigned eslutsky Sep 29, 2025

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2025

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 29, 2025

kasturinarra changed the title ~~Add HTTP01 ACME test for cert-manager~~ [USHIFT-5572] Add HTTP01 ACME test for cert-manager Sep 29, 2025

kasturinarra changed the title ~~[USHIFT-5572] Add HTTP01 ACME test for cert-manager~~ USHIFT-5572 Add HTTP01 ACME test for cert-manager Sep 29, 2025

kasturinarra changed the title ~~USHIFT-5572 Add HTTP01 ACME test for cert-manager~~ USHIFT-5572: Add HTTP01 ACME test for cert-manager Sep 29, 2025

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 29, 2025

openshift-merge-bot bot merged commit 152df35 into openshift:main Sep 29, 2025
9 checks passed

openshift-cherrypick-robot mentioned this pull request Sep 29, 2025

[release-4.20] USHIFT-5572: Add HTTP01 ACME test for cert-manager #5540

Merged

Conversation

kasturinarra commented Aug 13, 2025

Uh oh!

kasturinarra commented Aug 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

eslutsky Aug 18, 2025

Choose a reason for hiding this comment

Uh oh!

kasturinarra commented Sep 3, 2025

Uh oh!

kasturinarra commented Sep 3, 2025

Uh oh!

kasturinarra commented Sep 3, 2025

Uh oh!

kasturinarra commented Sep 3, 2025

Uh oh!

kasturinarra commented Sep 17, 2025

Uh oh!

kasturinarra commented Sep 17, 2025

Uh oh!

kasturinarra commented Sep 23, 2025

Uh oh!

kasturinarra commented Sep 24, 2025

Uh oh!

kasturinarra commented Sep 24, 2025

Uh oh!

Uh oh!

Uh oh!

kasturinarra commented Sep 26, 2025

Uh oh!

kasturinarra commented Sep 26, 2025

Uh oh!

eslutsky commented Sep 29, 2025

Uh oh!

openshift-ci bot commented Sep 29, 2025

Uh oh!

eslutsky commented Sep 29, 2025

Uh oh!

openshift-ci-robot commented Sep 29, 2025

Uh oh!

openshift-ci-robot commented Sep 29, 2025 • edited by openshift-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Sep 29, 2025

Uh oh!

openshift-ci bot commented Sep 29, 2025

Uh oh!

Uh oh!

kasturinarra commented Sep 29, 2025

Uh oh!

openshift-cherrypick-robot commented Sep 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

kasturinarra commented Aug 13, 2025 •

edited

Loading

openshift-ci-robot commented Sep 29, 2025 •

edited by openshift-ci bot

Loading