Skip to content

Fix some nits on various scripts#447

Merged
cooktheryan merged 1 commit intoopenshift:mainfrom
leo8a:main
Nov 16, 2021
Merged

Fix some nits on various scripts#447
cooktheryan merged 1 commit intoopenshift:mainfrom
leo8a:main

Conversation

@leo8a
Copy link
Contributor

@leo8a leo8a commented Nov 11, 2021

Double quoted on various scripts to prevent globbing and word splitting.

Signed-off-by: Leo Ochoa lochoa@redhat.com

@openshift-ci openshift-ci bot requested review from fzdarsky and mangelajo November 11, 2021 11:34
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Nov 11, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 11, 2021

Hi @leo8a. Thanks for your PR.

I'm waiting for a redhat-et member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cooktheryan
Copy link
Contributor

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 11, 2021
Double quoted on scripts to prevent globbing and word splitting (see SC2086).
@cooktheryan
Copy link
Contributor

/LGTM

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 15, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cooktheryan
To complete the pull request process, please assign copejon after the PR has been reviewed.
You can assign the PR to them by writing /assign @copejon in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants