Fix function name to be compatible with bash

[iranzo]

Script function name is not valid for bash, replacing "-" for "_" and shfmt -i 4 -w over the file

Closes #446

[openshift-ci]

Hi @iranzo. Thanks for your PR.

I'm waiting for a redhat-et member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign mangelajo after the PR has been reviewed.
You can assign the PR to them by writing /assign @mangelajo in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[oglok]

This PR is changing indentation across the whole file. Is there any reason for it?

[iranzo]

Applying shfmt over it via pre-commit :)

[oglok]

Applying shfmt over it via pre-commit :) -- Pablo Iranzo Gómez GnuPG: 0x5BD8E1E4 Web: https://iranzo.io || https://t.me/redken_bot El jue, 11 nov 2021 a las 12:56, Ricardo Noriega De Soto (< @.***>) escribió:
…
This PR is changing indentation across the whole file. Is there any reason for it? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#445 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACMJD2YVWURQGZXITELICTULOVQRANCNFSM5H2ES2EQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

We try to keep consistency of doing one thing per PR, and the indentation changes were not stated in the description. That's why I'm asking... :-)

[cooktheryan]

/assign oglok

[cooktheryan]

/ok-to-test

[copejon]

Script function name is not valid for bash, replacing "-" for "_" and shfmt -i 4 -w over the file

Is this causing an error that may be respective of your version of bash? Or was this just reported by shfmt as being non-idiomatic of bash function names? AFAICT, bash has no issues with hyphenated function names, and doesn't mention any special character other than $ as being off limits.

[cooktheryan]

Going to close as we will be deprecating install.sh in the near future