Skip to content

nightly image builds#414

Closed
cooktheryan wants to merge 1 commit intoopenshift:mainfrom
cooktheryan:nightly-aio
Closed

nightly image builds#414
cooktheryan wants to merge 1 commit intoopenshift:mainfrom
cooktheryan:nightly-aio

Conversation

@cooktheryan
Copy link
Contributor

@cooktheryan cooktheryan commented Nov 2, 2021

Closes: #413

@netlify
Copy link

netlify bot commented Nov 2, 2021 •
edited
Loading

✔️ Deploy Preview for microshift canceled.

🔨 Explore the source changes: 39aebe7

🔍 Inspect the deploy log: https://app.netlify.com/sites/microshift/deploys/6181962c51559c0008f7ef24

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 2, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign copejon after the PR has been reviewed.
You can assign the PR to them by writing /assign @copejon in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested a review from husky-parul November 2, 2021 19:49
@cooktheryan
Copy link
Contributor Author

cooktheryan commented Nov 2, 2021

/test e2e-openshift-conformance-sig-cli

mangelajo
mangelajo reviewed Nov 3, 2021
View reviewed changes
Copy link
Contributor

@mangelajo mangelajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an idea.

.github/workflows/nightly.yaml
- name: push assets
run: |
for i in `podman images --sort repository --format "{{.Repository}}:{{.Tag}}" quay.io/microshift/microshift-aio`; do
podman push $i
Copy link
Contributor

@mangelajo mangelajo Nov 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably publish them under a single multiarch manifest, see:

https://github.com/redhat-et/microshift/blob/ce1103717f3b91a1d5537a7473effe04fde2d74e/packaging/images/components/build.sh#L91
https://github.com/redhat-et/microshift/blob/ce1103717f3b91a1d5537a7473effe04fde2d74e/packaging/images/components/build.sh#L92
https://github.com/redhat-et/microshift/blob/ce1103717f3b91a1d5537a7473effe04fde2d74e/packaging/images/components/build.sh#L126
and
https://github.com/redhat-et/microshift/blob/ce1103717f3b91a1d5537a7473effe04fde2d74e/packaging/images/components/build.sh#L55

@cooktheryan
Copy link
Contributor Author

cooktheryan commented Nov 3, 2021

@mangelajo will patch this up in the morning

@cooktheryan cooktheryan mentioned this pull request Nov 4, 2021
Closed
@sallyom
Copy link
Contributor

sallyom commented Nov 9, 2021

/test e2e-rpm-install

@copejon
Copy link
Contributor

copejon commented Feb 2, 2022

/retest

This was referenced May 7, 2025
Closed
Closed
Closed
Closed
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mangelajo mangelajo mangelajo left review comments

@copejon copejon Awaiting requested review from copejon

@husky-parul husky-parul Awaiting requested review from husky-parul

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Enhancement]: Nightly AIO image

4 participants

@cooktheryan @sallyom @copejon @mangelajo