Skip to content

USHIFT-2925: Start using hypervisor container registry for ostreecontainer in kickstart#3596

Merged
openshift-merge-bot[bot] merged 4 commits intoopenshift:mainfrom
ggiguash:insecure_bootc_registry
Jul 9, 2024
Merged

USHIFT-2925: Start using hypervisor container registry for ostreecontainer in kickstart#3596
openshift-merge-bot[bot] merged 4 commits intoopenshift:mainfrom
ggiguash:insecure_bootc_registry

Conversation

@ggiguash
Copy link
Contributor

@ggiguash ggiguash commented Jul 7, 2024

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 7, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 7, 2024 •
edited by openshift-ci bot
Loading

@ggiguash: This pull request references USHIFT-2925 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 7, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 7, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ggiguash
Copy link
Contributor Author

ggiguash commented Jul 7, 2024

/test ?

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 7, 2024

@ggiguash: The following commands are available to trigger required jobs:

  • /test images
  • /test metal-bootc-test
  • /test metal-bootc-test-arm
  • /test metal-periodic-test
  • /test metal-periodic-test-arm
  • /test microshift-metal-cache
  • /test microshift-metal-cache-arm
  • /test microshift-metal-tests
  • /test microshift-metal-tests-arm
  • /test ocp-conformance-rhel-eus
  • /test ocp-conformance-rhel-eus-arm
  • /test ocp-full-conformance-rhel-eus
  • /test test-rpm
  • /test test-unit
  • /test verify

The following commands are available to trigger optional jobs:

  • /test test-rebase

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-microshift-main-images
  • pull-ci-openshift-microshift-main-metal-bootc-test
  • pull-ci-openshift-microshift-main-metal-bootc-test-arm
  • pull-ci-openshift-microshift-main-metal-periodic-test
  • pull-ci-openshift-microshift-main-metal-periodic-test-arm
  • pull-ci-openshift-microshift-main-microshift-metal-tests
  • pull-ci-openshift-microshift-main-microshift-metal-tests-arm
  • pull-ci-openshift-microshift-main-test-unit
  • pull-ci-openshift-microshift-main-verify
Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2024
@ggiguash
Copy link
Contributor Author

ggiguash commented Jul 7, 2024

/test metal-bootc-test
/test metal-bootc-test-arm

@ggiguash ggiguash marked this pull request as ready for review July 7, 2024 18:00
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 7, 2024
@ggiguash
Copy link
Contributor Author

ggiguash commented Jul 7, 2024

/assign @pacevedom

@openshift-ci openshift-ci bot requested review from copejon and pmtk July 7, 2024 18:01
@ggiguash ggiguash force-pushed the insecure_bootc_registry branch from 516dcfa to 9edf19a Compare July 7, 2024 18:03
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 7, 2024

@ggiguash: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

pacevedom
pacevedom approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@pacevedom pacevedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

test/bin/scenario.sh
DEFAULT_BOOT_BLUEPRINT="rhel-9.2"
LVM_SYSROOT_SIZE="10240"
WEB_SERVER_URL="http://${VM_BRIDGE_IP}:${WEB_SERVER_PORT}"
BOOTC_REGISTRY_URL="${VM_BRIDGE_IP}:5000"
Copy link
Contributor

@pacevedom pacevedom Jul 9, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we could use the same registry variables for both mirrors, but this shouldnt stop the PR.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pacevedom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit aeaa3b3 into openshift:main Jul 9, 2024
@ggiguash ggiguash deleted the insecure_bootc_registry branch July 9, 2024 12:08
This was referenced Jun 13, 2025
Closed
Closed
Closed
Closed
Closed
@microshift-rebase-script microshift-rebase-script bot mentioned this pull request Jun 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@copejon copejon Awaiting requested review from copejon

@pmtk pmtk Awaiting requested review from pmtk

1 more reviewer

@pacevedom pacevedom pacevedom approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@pacevedom pacevedom

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ggiguash @openshift-ci-robot @pacevedom