USHIFT-3733: add management annotation to topolvm pods

[eslutsky]

topolvm pods are the only who missing the target.workload.openshift.io/management annotation:

oc get pods -o jsonpath='{range .items[*]}{.metadata.name}{" -- "}{.metadata.annotations.target\.workload\.openshift\.io/management}{"\n"}{end}' -A
csi-snapshot-controller-75d4fbc9df-c7cpz -- {"effect":"PreferredDuringScheduling"}
csi-snapshot-webhook-8547f88946-ktj89 -- {"effect":"PreferredDuringScheduling"}
dns-default-grvvs -- {"effect": "Preferredoc get pods -o jsonpath='{range .items[*]}{.metadata.name}{" -- "}{.metadata.annotations.target\.workload\.openshift\.io/management}{"\n"}{end}' -A
csi-snapshot-controller-75d4fbc9df-c7cpz -- {"effect":"PreferredDuringScheduling"}
csi-snapshot-webhook-8547f88946-ktjoc get pods -o jsonpath='{range .items[*]}{.metadata.name}{" -- "}{.metadata.annotations.target\.workload\.openshift\.io/management}{"\n"}{end}' -A
csi-snapshot-controller-75d4fbc9df-c7cpz -- {"effect":"PreferredDuringScheduling"}
csi-snapshot-webhook-8547f88946-ktj89 -- {"effect":"PreferredDuringScheduling"}
dns-default-grvvs -- {"effect": "PreferredDuringScheduling"}
node-resolver-6vqsl -- {"effect": "PreferredDuringScheduling"}
router-default-c8f9c658f-bmjxr -- {"effect":"PreferredDuringScheduling"}
ovnkube-master-vmgfn -- {"effect": "PreferredDuringScheduling"}
ovnkube-node-hx9gn -- {"effect": "PreferredDuringScheduling"}
service-ca-66779bb75c-k7n7m -- {"effect": "PreferredDuringScheduling"}
topolvm-controller-8497cc4b9c-b5srf --
topolvm-node-jlfpv -- 89 -- {"effect":"PreferredDuringScheduling"}
dns-default-grvvs -- {"effect": "PreferredDuringScheduling"}
node-resolver-6vqsl -- {"effect": "PreferredDuringScheduling"}
router-default-c8f9c658f-bmjxr -- {"effect":"PreferredDuringScheduling"}
ovnkube-master-vmgfn -- {"effect": "PreferredDuringScheduling"}
ovnkube-node-hx9gn -- {"effect": "PreferredDuringScheduling"}
service-ca-66779bb75c-k7n7m -- {"effect": "PreferredDuringScheduling"}
topolvm-controller-8497cc4b9c-b5srf --
topolvm-node-jlfpv -- DuringScheduling"}
node-resolver-6vqsl -- {"effect": "PreferredDuringScheduling"}
router-default-c8f9c658f-bmjxr -- {"effect":"PreferredDuringScheduling"}
ovnkube-master-vmgfn -- {"effect": "PreferredDuringScheduling"}
ovnkube-node-hx9gn -- {"effect": "PreferredDuringScheduling"}
service-ca-66779bb75c-k7n7m -- {"effect": "PreferredDuringScheduling"}
topolvm-controller-8497cc4b9c-b5srf --
topolvm-node-jlfpv --

[jakobmoellerdev]

LGTM on LVMS side, this has been forgotten in the microshift components

[openshift-ci-robot]

@eslutsky: This pull request references USHIFT-3733 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.

Details

In response to this:

topolvm pods are the only who missing the target.workload.openshift.io/management annotation:

oc get pods -o jsonpath='{range .items[*]}{.metadata.name}{" -- "}{.metadata.annotations.target\.workload\.openshift\.io/management}{"\n"}{end}' -A
csi-snapshot-controller-75d4fbc9df-c7cpz -- {"effect":"PreferredDuringScheduling"}
csi-snapshot-webhook-8547f88946-ktj89 -- {"effect":"PreferredDuringScheduling"}
dns-default-grvvs -- {"effect": "Preferredoc get pods -o jsonpath='{range .items[*]}{.metadata.name}{" -- "}{.metadata.annotations.target\.workload\.openshift\.io/management}{"\n"}{end}' -A
csi-snapshot-controller-75d4fbc9df-c7cpz -- {"effect":"PreferredDuringScheduling"}
csi-snapshot-webhook-8547f88946-ktjoc get pods -o jsonpath='{range .items[*]}{.metadata.name}{" -- "}{.metadata.annotations.target\.workload\.openshift\.io/management}{"\n"}{end}' -A
csi-snapshot-controller-75d4fbc9df-c7cpz -- {"effect":"PreferredDuringScheduling"}
csi-snapshot-webhook-8547f88946-ktj89 -- {"effect":"PreferredDuringScheduling"}
dns-default-grvvs -- {"effect": "PreferredDuringScheduling"}
node-resolver-6vqsl -- {"effect": "PreferredDuringScheduling"}
router-default-c8f9c658f-bmjxr -- {"effect":"PreferredDuringScheduling"}
ovnkube-master-vmgfn -- {"effect": "PreferredDuringScheduling"}
ovnkube-node-hx9gn -- {"effect": "PreferredDuringScheduling"}
service-ca-66779bb75c-k7n7m -- {"effect": "PreferredDuringScheduling"}
topolvm-controller-8497cc4b9c-b5srf --
topolvm-node-jlfpv -- 89 -- {"effect":"PreferredDuringScheduling"}
dns-default-grvvs -- {"effect": "PreferredDuringScheduling"}
node-resolver-6vqsl -- {"effect": "PreferredDuringScheduling"}
router-default-c8f9c658f-bmjxr -- {"effect":"PreferredDuringScheduling"}
ovnkube-master-vmgfn -- {"effect": "PreferredDuringScheduling"}
ovnkube-node-hx9gn -- {"effect": "PreferredDuringScheduling"}
service-ca-66779bb75c-k7n7m -- {"effect": "PreferredDuringScheduling"}
topolvm-controller-8497cc4b9c-b5srf --
topolvm-node-jlfpv -- DuringScheduling"}
node-resolver-6vqsl -- {"effect": "PreferredDuringScheduling"}
router-default-c8f9c658f-bmjxr -- {"effect":"PreferredDuringScheduling"}
ovnkube-master-vmgfn -- {"effect": "PreferredDuringScheduling"}
ovnkube-node-hx9gn -- {"effect": "PreferredDuringScheduling"}
service-ca-66779bb75c-k7n7m -- {"effect": "PreferredDuringScheduling"}
topolvm-controller-8497cc4b9c-b5srf --
topolvm-node-jlfpv --

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[eslutsky]

/retest

[copejon]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: copejon, eslutsky

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [copejon,eslutsky]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@eslutsky: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.