Skip to content

USHIFT-3480: exclude fips tests from 4.17#3505

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
eslutsky:exclude-fips-from-4.17
Jun 20, 2024
Merged

USHIFT-3480: exclude fips tests from 4.17#3505
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
eslutsky:exclude-fips-from-4.17

Conversation

@eslutsky
Copy link
Contributor

fips check-payload missing golang-1.22 symobls in 4.17 , temporarily disabling fips tests from periodics.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 18, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 18, 2024

@eslutsky: This pull request references USHIFT-3480 which is a valid jira issue.

Details

In response to this:

fips check-payload missing golang-1.22 symobls in 4.17 , temporarily disabling fips tests from periodics.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ggiguash
Copy link
Contributor

@eslutsky , can be rename the files to .disabled instead of deleting them?

@openshift-ci openshift-ci bot requested review from ggiguash and pmtk June 18, 2024 13:49
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2024
Signed-off-by: Evgeny Slutsky <eslutsky@dhcp-1-214.lcy.redhat.com>
@eslutsky eslutsky force-pushed the exclude-fips-from-4.17 branch from f3ca495 to 045b940 Compare June 18, 2024 14:29
@ggiguash
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eslutsky, ggiguash

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD dbe80c3 and 2 for PR HEAD 045b940 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e9533cf and 1 for PR HEAD 045b940 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 2cf0fbd and 0 for PR HEAD 045b940 in total

@eslutsky
Copy link
Contributor Author

/test metal-periodic-test

@openshift-ci-robot
Copy link

/hold

Revision 045b940 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 19, 2024
@eslutsky
Copy link
Contributor Author

test is failing because of aws infra capacity issue.

@eslutsky
Copy link
Contributor Author

/test metal-periodic-test

1 similar comment
@ggiguash
Copy link
Contributor

/test metal-periodic-test

@eslutsky
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 20, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 20, 2024

@eslutsky: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants