Skip to content

iptables-legacy support for AIO#349

Merged
rootfs merged 1 commit intoopenshift:mainfrom
mangelajo:aio-iptables-legacy-support
Oct 27, 2021
Merged

iptables-legacy support for AIO#349
rootfs merged 1 commit intoopenshift:mainfrom
mangelajo:aio-iptables-legacy-support

Conversation

@mangelajo
Copy link
Contributor

@mangelajo mangelajo commented Oct 20, 2021 •
edited
Loading

This allows using non-nft enabled kernels, like the ubuntu 18.04LTS on the Nvidia Jetson boards

 make build-containerized-all-in-one-iptables-arm64 FROM_SOURCE=true

or

 make build-containerized-all-in-one-iptables-arm64

Signed-off-by: Miguel Angel Ajo majopela@redhat.com

@openshift-ci openshift-ci bot requested review from copejon and fzdarsky October 20, 2021 14:12
@mangelajo mangelajo marked this pull request as draft October 20, 2021 14:12
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 20, 2021
@mangelajo mangelajo force-pushed the aio-iptables-legacy-support branch from 1a19169 to 10791d1 Compare October 20, 2021 20:25
@mangelajo mangelajo marked this pull request as ready for review October 20, 2021 20:27
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 20, 2021
@mangelajo
Copy link
Contributor Author

mangelajo commented Oct 20, 2021

/assign rootfs

@mangelajo mangelajo force-pushed the aio-iptables-legacy-support branch from 10791d1 to c732da0 Compare October 20, 2021 20:29
@rootfs
Copy link
Member

rootfs commented Oct 21, 2021

/lgtm

/assign @copejon

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 21, 2021
copejon
copejon reviewed Oct 25, 2021
View reviewed changes
Makefile Outdated
Copy link
Contributor

@copejon copejon Oct 25, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the intent to release all permutations of arch and nft/iptables? If not, then we don't need to tag it.

Copy link
Contributor Author

@mangelajo mangelajo Oct 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, that's the intention. We need a different tag sadly.

There are tricks to pack both versions of iptables, but nothing compatible with ubi8. We could potentially do that if we packed in fedora instead. Anyway, multiple tags / permutations may work for now.

@mangelajo
iptables-legacy support for AIO
3ee2d11 
Signed-off-by: Miguel Angel Ajo <majopela@redhat.com>
@mangelajo mangelajo force-pushed the aio-iptables-legacy-support branch from c732da0 to 3ee2d11 Compare October 26, 2021 09:12
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 26, 2021
@netlify
Copy link

netlify bot commented Oct 26, 2021 •
edited
Loading

❌ Deploy Preview for microshift failed.

🔨 Explore the source changes: 3ee2d11

🔍 Inspect the deploy log: https://app.netlify.com/sites/microshift/deploys/6177fea004583e37ef3b4ef1

@mangelajo
Copy link
Contributor Author

mangelajo commented Oct 26, 2021

/retest

The failed tests are unrelated actually

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 26, 2021 •
edited
Loading

@mangelajo: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openshift-conformance-sig-network 3ee2d11 link false /test e2e-openshift-conformance-sig-network
ci/prow/e2e-openshift-conformance-sig-storage 3ee2d11 link false /test e2e-openshift-conformance-sig-storage
ci/prow/e2e-openshift-conformance-sig-api-machinery 3ee2d11 link false /test e2e-openshift-conformance-sig-api-machinery

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rootfs
Copy link
Member

rootfs commented Oct 27, 2021

CI test failures are not related to the PR
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 27, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 27, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rootfs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rootfs rootfs merged commit de26283 into openshift:main Oct 27, 2021
@microshift-rebase-script microshift-rebase-script bot mentioned this pull request Sep 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@copejon copejon copejon left review comments

@fzdarsky fzdarsky Awaiting requested review from fzdarsky

Assignees

@copejon copejon

@rootfs rootfs

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mangelajo @rootfs @copejon