Skip to content

USHIFT-3315: Increase delete openshift-ingress pod timeout#3439

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
agullon:fix_router_RF_test
Jun 5, 2024
Merged

USHIFT-3315: Increase delete openshift-ingress pod timeout#3439
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
agullon:fix_router_RF_test

Conversation

@agullon
Copy link
Contributor

@agullon agullon commented Jun 5, 2024

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 5, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 5, 2024

@agullon: This pull request references USHIFT-3315 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.17.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from ggiguash and jerpeter1 June 5, 2024 12:46
... Disable Router

Run With Kubeconfig oc wait --for=delete namespace/openshift-ingress --timeout=60s
Run With Kubeconfig oc wait --for=delete namespace/openshift-ingress --timeout=300s
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain where we need this change? I do not remember this command expiring in MicroShift CI.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When running RF test suite in QE environment, RF tests execution is stuck in Router Suite Teardown. This is because the pod on openshift-ingress namespace takes more than 60 seconds to be deleted, so teardown process fails and no other RF test is executed. So I tested increasing the timeout and this is issue is no longer reproducible.

@ggiguash
Copy link
Contributor

ggiguash commented Jun 5, 2024

/lgtm
/test microshift-metal-tests

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: agullon, ggiguash

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 5, 2024

@agullon: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 7f65ee6 into openshift:main Jun 5, 2024
@agullon
Copy link
Contributor Author

agullon commented Jun 5, 2024

/cherry-pick release-4.16

@openshift-cherrypick-robot

@agullon: new pull request created: #3440

Details

In response to this:

/cherry-pick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants