USHIFT-3113: Enhancements for build_bootc_image.py script#3293
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@ggiguash: This pull request references USHIFT-3113 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
approved
ggiguash
changed the title
ggiguash
force-pushed
the
bootc_script_enhancements
branch
2 times, most recently
from
eeaeaab to
47ab45b
Compare
ggiguash
force-pushed
the
bootc_script_enhancements
branch
from
47ab45b to
25e1c62
Compare
| pids = [] | ||
| for child in children: | ||
| pids += [child.pid] | ||
| return pids |
There was a problem hiding this comment.
This might be a good place to use yield, but up to you. Not that it matters performance wise, but its good practice to do so if you dont need the full list upfront.
There was a problem hiding this comment.
In this case, I think I'd prefer to simpify the code and not use yield. The list will be very short and collected immediately, I'm not sure there's an advantage of using generators here, or is there?
|
/assign @pacevedom |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ggiguash, pacevedom The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@ggiguash: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
3 participants
These changes should attain a usability feature parity with the build_images.sh script:
--build-typeargument allows for filtering build by a specified type--no-extract-imagesskips container image extraction procedure