Skip to content

[release-4.15] USHIFT-2810: update multiplatform builder image#3206

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.15from
eslutsky:USHIFT-2810-change-go-builder
Apr 4, 2024
Merged

[release-4.15] USHIFT-2810: update multiplatform builder image#3206
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.15from
eslutsky:USHIFT-2810-change-go-builder

Conversation

@eslutsky
Copy link
Contributor

@eslutsky eslutsky commented Apr 2, 2024

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 2, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 2, 2024

@eslutsky: This pull request references USHIFT-2810 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.z" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from copejon and jogeo April 2, 2024 08:44
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2024
@eslutsky
Copy link
Contributor Author

eslutsky commented Apr 2, 2024

@thegreyd FYI

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this multiarch too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, validated with :

oc image info registry.ci.openshift.org/ocp/builder:rhel-9-golang-1.20-openshift-4.15 --filter-by-os linux/arm64

Copy link
Contributor Author

@eslutsky eslutsky Apr 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like rhel-9-golang-1.20-openshift-4.15 tag doesnt work with arm, so we must use rhel-9-golang-1.20-builder-multi-openshift-4.16 which is the same image but mutli arch.

Copy link
Contributor

@pacevedom pacevedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@pacevedom pacevedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label cherry-pick-approved
/label backport-risk-assessed

@openshift-ci openshift-ci bot added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. labels Apr 2, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2024
@pacevedom
Copy link
Contributor

/lgtm cancel
There is some trouble with the iamge arch

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 2, 2024
@eslutsky
Copy link
Contributor Author

eslutsky commented Apr 2, 2024

/lgtm cancel There is some trouble with the iamge arch

@thegreyd , looks like registry.ci.openshift.org/ocp/builder:rhel-9-golang-1.20-openshift-4.15 doesnt support ARM,
so we must use http://registry.ci.openshift.org/ocp/builder:rhel-9-golang-1.20-builder-multi-openshift-4.16 ?

@eslutsky eslutsky force-pushed the USHIFT-2810-change-go-builder branch 2 times, most recently from 55b5770 to ff9aa10 Compare April 2, 2024 12:50
Signed-off-by: Evgeny Slutsky <eslutsky@redhat.com>
@eslutsky eslutsky force-pushed the USHIFT-2810-change-go-builder branch from ff9aa10 to 7676b98 Compare April 2, 2024 12:51
@pacevedom
Copy link
Contributor

pacevedom commented Apr 4, 2024

/rename [release-4.15] USHIFT-2810: update multiplatform builder image

@pacevedom
Copy link
Contributor

/retitle [release-4.15] USHIFT-2810: update multiplatform builder image

@openshift-ci openshift-ci bot changed the title USHIFT-2810: update multiplatform builder image [release-4.15] [USHIFT-2810](https://issues.redhat.com//browse/USHIFT-2810): update multiplatform builder image Apr 4, 2024
@openshift-ci-robot openshift-ci-robot removed the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 4, 2024
@openshift-ci-robot
Copy link

@eslutsky: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pacevedom
Copy link
Contributor

/label jira/valid-bug

@openshift-ci openshift-ci bot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Apr 4, 2024
Copy link
Contributor

@pacevedom pacevedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eslutsky, pacevedom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pacevedom
Copy link
Contributor

pacevedom commented Apr 4, 2024

/retitle [release-4.15] USHIFT-2810: update multiplatform builder image

@openshift-ci openshift-ci bot changed the title [release-4.15] [USHIFT-2810](https://issues.redhat.com//browse/USHIFT-2810): update multiplatform builder image [release-4.15] USHIFT-2810: update multiplatform builder image Apr 4, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 4, 2024

@eslutsky: This pull request references USHIFT-2810 which is a valid jira issue.

Retaining the jira/valid-bug label as it was manually added.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 4, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 4, 2024

@eslutsky: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


# Specify OCP build tools image tag when building rpm with podman
RPM_BUILDER_IMAGE_TAG := rhel-9-golang-latest-openshift-4.15
RPM_BUILDER_IMAGE_TAG := rhel-9-golang-1.20-builder-multi-openshift-4.16
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add an explanation in the comment on why we're using 4.16 package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants