Embed git tags, commit ID and tree status in srpm#305
Embed git tags, commit ID and tree status in srpm#305fzdarsky merged 1 commit intoopenshift:mainfrom
Conversation
|
Hi @mangelajo. Thanks for your PR. I'm waiting for a redhat-et member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
needs-ok-to-test
|
/approve |
openshift-ci
bot
added
the
approved
|
/assign @copejon |
mangelajo
force-pushed
the
embed-srpm-git-details
branch
from
86061af to
f6544e6
Compare
|
✔️ Deploy Preview for microshift canceled. 🔨 Explore the source changes: a227f56e658a773d0f6e2787a692be1db334ab5d 🔍 Inspect the deploy log: https://app.netlify.com/sites/microshift/deploys/617bbf9f91f49c000721022a |
mangelajo
force-pushed
the
embed-srpm-git-details
branch
from
f6544e6 to
a227f56
Compare
|
@mangelajo: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Embedding those details, and then injecting then back during srpm building (instead of looking for the git details which doesn't exist anymore for an srpm build -it's a tarball-) allows for microshift being properly compiled with those details in the binary. Signed-off-by: Miguel Angel Ajo <majopela@redhat.com>
mangelajo
force-pushed
the
embed-srpm-git-details
branch
from
a227f56 to
85c4540
Compare
|
Re-tested manually the srpm / rpm building, this is good to go |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fzdarsky, rootfs The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 participants
Embedding those details, and then injecting then back during
srpm building (instead of looking for the git details which
doesn't exist anymore for an srpm build -it's a tarball-)
allows for microshift being properly compiled with those
details in the binary.
Closes-Issue: #476
Signed-off-by: Miguel Angel Ajo majopela@redhat.com