Skip to content

[release-4.15] OCPBUGS-28606: Make lvmo version visible to users via configmap#2946

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.15from
openshift-cherrypick-robot:cherry-pick-2789-to-release-4.15
Jan 31, 2024
Merged

[release-4.15] OCPBUGS-28606: Make lvmo version visible to users via configmap#2946
openshift-merge-bot[bot] merged 1 commit intoopenshift:release-4.15from
openshift-cherrypick-robot:cherry-pick-2789-to-release-4.15

Conversation

@openshift-cherrypick-robot
Copy link
Copy Markdown

@openshift-cherrypick-robot openshift-cherrypick-robot commented Jan 29, 2024

This is an automated cherry-pick of #2789

/assign copejon

@copejon
dump version during download, read during manifest gen
a4809a4 
write CM to kube-public ns

Signed-off-by: Jon Cope <jcope@redhat.com>

add lvms version cm to openshift-storage ns

Signed-off-by: Jon Cope <jcope@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 29, 2024
Merged
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jan 29, 2024

@openshift-cherrypick-robot: Jira Issue OCPBUGS-22216 has been cloned as Jira Issue OCPBUGS-28606. Will retitle bug to link to clone.
/retitle [release-4.15] OCPBUGS-28606: Make lvmo version visible to users via configmap

Details

In response to this:

This is an automated cherry-pick of #2789

/assign copejon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@copejon
Copy link
Copy Markdown
Contributor

copejon commented Jan 29, 2024

/backport-risk-assessed

@openshift-ci openshift-ci bot changed the title [release-4.15] OCPBUGS-22216: Make lvmo version visible to users via configmap [release-4.15] OCPBUGS-28606: Make lvmo version visible to users via configmap Jan 29, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 29, 2024
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jan 29, 2024

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-28606, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.0) matches configured target version for branch (4.15.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-22216 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-22216 targets the "4.16.0" version, which is one of the valid target versions: 4.16.0
  • bug has dependents

Requesting review from QA contact:
/cc @jogeo

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #2789

/assign copejon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jan 29, 2024
@openshift-ci openshift-ci bot requested review from dhellmann, jogeo and pliurh January 29, 2024 23:11
@copejon
Copy link
Copy Markdown
Contributor

copejon commented Jan 31, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2024
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jan 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: copejon, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2024
@copejon
Copy link
Copy Markdown
Contributor

copejon commented Jan 31, 2024

/backport-risk-assessed
/cherry-pick-approved

@copejon
Copy link
Copy Markdown
Contributor

copejon commented Jan 31, 2024

/label backport-risk-assessed
/label cherry-pick-approved

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jan 31, 2024
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jan 31, 2024

@copejon: Can not set label cherry-pick-approved: Must be member in one of these teams: []

Details

In response to this:

/label backport-risk-assessed
/label cherry-pick-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dhensel-rh
Copy link
Copy Markdown
Contributor

dhensel-rh commented Jan 31, 2024

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 31, 2024
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Jan 31, 2024

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 40524ac into openshift:release-4.15 Jan 31, 2024
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jan 31, 2024

@openshift-cherrypick-robot: Jira Issue OCPBUGS-28606 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state.

Details

In response to this:

This is an automated cherry-pick of #2789

/assign copejon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jogeo jogeo Awaiting requested review from jogeo

@dhellmann dhellmann Awaiting requested review from dhellmann

@pliurh pliurh Awaiting requested review from pliurh

Assignees

@copejon copejon

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@openshift-cherrypick-robot @openshift-ci-robot @copejon @dhensel-rh