add fully aio systemd unit file and script#292
Conversation
hack/all-in-one/microshift-aio-run
Outdated
There was a problem hiding this comment.
I wanted a file with the location of the KUBECONFIG like so:
cat <<EOF > /etc/microshift-aio/microshift-aio.conf
export KUBECONFIG=$(/usr/bin/podman volume inspect microshift-vol --format "{{.Mountpoint}}")/microshift/resources/kubeadmin/kubeconfig
EOF
I could not see a better way of getting that path from the service, but that is definitely extra and does not need to be included in the service. I figured it saves users from having to look up the path.
There was a problem hiding this comment.
I also could not figure out how to run ExecStartPost=source /etc/microshift-aio/microshift-aio.conf
I tried ExecStartPost=source, ExecStartPost=/bin/bash source etc, nothing worked but there is def something that does, I gave up and pushed the commit but will keep looking
There was a problem hiding this comment.
@husky-parul if you find something that works or if we decide it's not necessary, you can remove it, feel free to squash/amend, too
There was a problem hiding this comment.
this probably doesn't need, since the container starts with --rm
fef0b66 to
461a51d
Compare
Signed-off-by: Sally O'Malley <somalley@redhat.com> Signed-off-by: Parul Singh <parsingh@redhat.com> Co-authored-by: Sally O'Malley <parsingh@redhat.com> Co-authored-by: Parul Singh <parsingh@redhat.com>
461a51d to
f216081
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rootfs The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Sally O'Malley somalley@redhat.com
Signed-off-by: Parul Singh parsingh@redhat.com
Which issue(s) this PR addresses:
This PR partially resolves #276
This PR:
Adds a systemd unit file to run microshift all-in-one with podman
The service:
microshift-volpodman volume if it does not existsource /etc/microshift-aio/microshift-aio.confupon service startupsystemctl stop microshift-aoimicroshift-volis not deleted