Create initial spec for RPM packaging#288
Conversation
This can be built with: ``` $ spectool -g -R microshift.spec $ rpmbuild -ba microshift.spec ``` Related-Issue: openshift#278 Signed-off-by: Miguel Angel Ajo <majopela@redhat.com>
|
Hi @mangelajo. Thanks for your PR. I'm waiting for a redhat-et member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
microshift.spec
Outdated
|
|
||
| %install | ||
| install -d %{buildroot}%{_bindir} | ||
| install -p -m 755 ./_output/microshift %{buildroot}%{_bindir}/microshift |
There was a problem hiding this comment.
can you also add selinux modules here? or it goes to another rpm?
There was a problem hiding this comment.
Yes, that was my plan as per conversation in #277 (comment)
I can do that if @cooktheryan is ok :)
|
|
||
| Name: microshift | ||
| Version: %{version} | ||
| Release: %{release}%{dist} |
There was a problem hiding this comment.
It comes from rpmbuild, normally the distro where you are building, or, a mock envionment created by the builder that you request for a specific distro.
I passed the output SRPM from this, and https://copr.fedorainfracloud.org/coprs/mangelajo/microshift/build/2829853/
I was thinking that we could automate that for every tag, and then have one for every new git commit in the form of "devel" version and "%{timestamp}.git%{commit-sha}" release.
There was a problem hiding this comment.
i see, thanks for the education.
|
/approve |
|
Thanks for the eyes @rootfs |
|
/lgtm |
|
@rootfs Probably we should add the service definition and install it/enable it as soon as the RPM is installed? |
|
Probably we should also add dependencies (cri-o cri-tools) |
|
@mangelajo feel free to package them together. I can get you the required steps to generate the .pp file if you need them. Most items you should be able to derive from the install.sh |
* Support local builds + `make devel-rpm` and `make devel-srpm`. * Started changelog * Add systemd unit files * Create necessary directories (from install.sh)
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rootfs The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This can be built with the following commands for a release (download the source from github)
And with the following commands for local development and changes:
Related-Issue: #278
Signed-off-by: Miguel Angel Ajo majopela@redhat.com