Skip to content

USHIFT-1705: feat: re-add /usr/lib check for kustomize#2403

Merged
openshift-merge-robot merged 1 commit intoopenshift:mainfrom
eggfoobar:update-kustomize-test
Sep 28, 2023
Merged

USHIFT-1705: feat: re-add /usr/lib check for kustomize#2403
openshift-merge-robot merged 1 commit intoopenshift:mainfrom
eggfoobar:update-kustomize-test

Conversation

@eggfoobar
Copy link
Contributor

added logic to make /usr/lib writable during test, rebooting will revert back to immutable filesystem

local testing didn't show an increase in test time for the kustomize test itself, looking at previous runs, this test was around 2 minutes, and even with the reboot, it seems to hover around there.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 26, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 26, 2023

@eggfoobar: This pull request references USHIFT-1705 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set.

Details

In response to this:

added logic to make /usr/lib writable during test, rebooting will revert back to immutable filesystem

local testing didn't show an increase in test time for the kustomize test itself, looking at previous runs, this test was around 2 minutes, and even with the reboot, it seems to hover around there.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 26, 2023
@eggfoobar eggfoobar force-pushed the update-kustomize-test branch from 17cfe2d to e69f7af Compare September 26, 2023 18:35
@eggfoobar
Copy link
Contributor Author

/retest-required

1 similar comment
@eggfoobar
Copy link
Contributor Author

/retest-required

@pmtk
Copy link
Member

pmtk commented Sep 27, 2023

This approach makes sense, beside two small nits looks good to me

@eggfoobar eggfoobar force-pushed the update-kustomize-test branch from e69f7af to 492d701 Compare September 27, 2023 16:21
@eggfoobar
Copy link
Contributor Author

/retest-required

added logic to make /usr/lib writable during test, rebooting will revert back to immutable filesystem

Signed-off-by: ehila <ehila@redhat.com>
@eggfoobar eggfoobar force-pushed the update-kustomize-test branch from 492d701 to b971e0c Compare September 28, 2023 03:49
@pmtk
Copy link
Member

pmtk commented Sep 28, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 28, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eggfoobar, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pmtk
Copy link
Member

pmtk commented Sep 28, 2023

/test microshift-metal-tests

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 28, 2023

@eggfoobar: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants