USHIFT-1086: Refuse to start if versions of data and executable are different, refuse migration if data version > exec version#1900
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@pmtk: This pull request references USHIFT-1086 which is a valid jira issue. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
approved
pmtk
changed the title
pkg/admin/prerun/version.go
Outdated
| } | ||
|
|
||
| type versionMetadata struct { | ||
| X, Y int |
There was a problem hiding this comment.
We talk about x, y, and z but those aren't very meaningful field names. Maybe "Major" and "Minor"?
| } | ||
|
|
||
| dataVer, err := getVersionOfData() | ||
| if err != nil { |
There was a problem hiding this comment.
The logic below this point would be easier to unit test if it was pulled out into its own function so the test suite could pass the execVer and dataVer values for different scenarios.
There was a problem hiding this comment.
I intended that initially but was discouraged by no protection from passing params in wrong order and doing checks wrong. but the ut argument is valid so i'll change it
pmtk
force-pushed
the
1086-version-lower-refuse
branch
from
082be1c to
f73e3c8
Compare
|
@pmtk: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhellmann, pmtk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 participants
No description provided.